Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvclient(ticdc): add worker busy monitor #10389

Merged
merged 5 commits into from
Jan 3, 2024
Merged

kvclient(ticdc): add worker busy monitor #10389

merged 5 commits into from
Jan 3, 2024

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Dec 29, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #10388

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Dec 29, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 29, 2023
asddongmen
asddongmen reviewed Jan 2, 2024
View reviewed changes
cdc/kv/metrics.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 2, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 2, 2024
hicqu
hicqu reviewed Jan 2, 2024
View reviewed changes
cdc/kv/client.go Outdated Show resolved Hide resolved
hicqu
hicqu reviewed Jan 2, 2024
View reviewed changes
cdc/kv/client.go Show resolved Hide resolved
hicqu
hicqu reviewed Jan 3, 2024
View reviewed changes
cdc/kv/client.go Outdated Show resolved Hide resolved
@hicqu
Copy link
Contributor

hicqu commented Jan 3, 2024

Rest LGTM.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 3, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, hicqu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 3, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-02 00:51:42.777807054 +0000 UTC m=+2131793.815033966: ☑️ agreed by asddongmen.
  • 2024-01-03 03:43:06.136461428 +0000 UTC m=+2228477.173688340: ☑️ agreed by hicqu.

@CharlesCheung96
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 4c31fda into pingcap:master Jan 3, 2024
13 of 14 checks passed
@CharlesCheung96 CharlesCheung96 added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Jan 3, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #10410.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 3, 2024
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #10411.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 3, 2024
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#10389
78d6d11 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 3, 2024
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#10389
d321d73 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
This was referenced Jan 3, 2024
Closed
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #10412.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 3, 2024
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#10389
a4b263b 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Jan 25, 2024
@ti-chi-bot
kvclient(ticdc): add worker busy monitor (#10389) (#10412)
e5999e3 
close #10388
@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 7, 2024
@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hicqu hicqu hicqu approved these changes

@asddongmen asddongmen asddongmen approved these changes

@sdojjy sdojjy Awaiting requested review from sdojjy

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

record worker busy ratio in kvclient
4 participants
@CharlesCheung96 @hicqu @ti-chi-bot @asddongmen