Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert prometheus client_golang from from v1.12.2 to v1.11.0 #5494

Closed
maxshuang opened this issue May 20, 2022 · 1 comment · Fixed by #5495 or #5643
Closed

Revert prometheus client_golang from from v1.12.2 to v1.11.0 #5494

maxshuang opened this issue May 20, 2022 · 1 comment · Fixed by #5495 or #5643
Assignees
Labels
affects-6.1 area/engine Issues or PRs related to Dataflow Engine. area/ticdc Issues or PRs related to TiCDC. severity/minor type/bug The issue is confirmed as a bug.

Comments

@maxshuang
Copy link
Contributor

What did you do?

When merge engine to tiflow repo, client_golang(v1.12.2) will introduce some incompatible change to the go collector and some metric name.

Detail
ref : https://github.com/prometheus/client_golang/releases
[CHANGE] ⚠️ Change in collectors.NewGoCollector metrics: Reverting addition of new ~80 runtime metrics by default. You can enable this back with GoRuntimeMetricsCollection option or GoRuntimeMemStatsCollection | GoRuntimeMetricsCollection for smooth transition.
[BUGFIX] Fixed the bug that causes generated histogram metric names to end with _total. ⚠️ This changes 3 metric names in the new Go collector that was reverted from default in this release.
go_gc_heap_allocs_by_size_bytes_total -> go_gc_heap_allocs_by_size_bytes,
go_gc_heap_frees_by_size_bytes_total -> go_gc_heap_allocs_by_size_bytes
go_gc_pauses_seconds_total -> go_gc_pauses_seconds.

What did you expect to see?

No response

What did you see instead?

some go collector metric lost

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

(paste TiDB cluster version here)

Upstream TiKV version (execute tikv-server --version):

(paste TiKV version here)

TiCDC version (execute cdc version):

master
@Ehco1996
Copy link
Contributor

reopen because #5393 upgrade promtheus_client again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.1 area/engine Issues or PRs related to Dataflow Engine. area/ticdc Issues or PRs related to TiCDC. severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
3 participants