Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove tiflash-proxy for tiflash_compute mode #6588

Merged
merged 11 commits into from
Jan 30, 2023
Merged

remove tiflash-proxy for tiflash_compute mode #6588

merged 11 commits into from
Jan 30, 2023

Conversation

guo-shaoge
Copy link
Contributor

@guo-shaoge guo-shaoge commented Jan 5, 2023 •
edited
Loading

Signed-off-by: guo-shaoge shaoge1994@163.com

What problem does this PR solve?

Issue Number: close #6666

Problem Summary:
TODO: key_manager is mock for now, we need to add new key_manager using ffi. : #6667

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 5, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CalvinNeo
  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 5, 2023
@guo-shaoge
remove tiflash-proxy for tiflash_compute mode
84bd669 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ywqzzy
Copy link
Contributor

ywqzzy commented Jan 5, 2023

IMO, if we disable tiflash_proxy, we don't have to use TiFlashProxyConfig and RaftStoreProxyRunner will not be inited.

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 13, 2023
@guo-shaoge
storage metrics disable in disaggregated compute mode
865654b 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@guo-shaoge
Merge branch 'remove_proxy_for_tiflash_compute' of github.com:guo-sha…
b99673c 
…oge/tiflash into remove_proxy_for_tiflash_compute
@guo-shaoge
misuse isDisaggregatedStorageMode
41b4ca6 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
CalvinNeo
CalvinNeo approved these changes Jan 28, 2023
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 28, 2023
@guo-shaoge
fix comment
cffa468 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
windtalker
windtalker approved these changes Jan 29, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guo-shaoge
Copy link
Contributor Author

/run-all-tests

JaySon-Huang
JaySon-Huang approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

dbms/src/Flash/DiagnosticsService.cpp
Comment on lines +41 to +46
if (context.isDisaggregatedComputeMode())
{
String err_msg = "tiflash compute node should be managed by AutoScaler instead of PD, this grpc should not be called be AutoScaler for now";
LOG_ERROR(log, err_msg);
return ::grpc::Status(::grpc::StatusCode::INTERNAL, err_msg);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this affect the info shown in dashboard?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dashboard fetch store info from PD, after this pr, tiflash_compute will be managed by AutoScaler, so Dashboard cannot see tiflash_compute nodes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.
We'd better have a proposal on integrating tiflash_compute (and maybe auto-scaler) with dashboard in the future. Getting flame graphs from dashboard is a useful tool for development.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 30, 2023
@guo-shaoge
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@guo-shaoge: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 00ab401

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 30, 2023
@ti-chi-bot
Copy link
Member

@guo-shaoge: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit a297907 into pingcap:master Jan 30, 2023
This was referenced Jan 31, 2023
Merged
Closed
ywqzzy pushed a commit to ywqzzy/tiflash_1 that referenced this pull request Feb 13, 2023
@guo-shaoge @ywqzzy
remove tiflash-proxy for tiflash_compute mode (pingcap#6588)
938bf07 
close pingcap#6666

Signed-off-by: ywqzzy <592838129@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@windtalker windtalker windtalker approved these changes

@CalvinNeo CalvinNeo CalvinNeo approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove proxy in disaggregated tiflash_compute mode
7 participants
@guo-shaoge @ti-chi-bot @ywqzzy @windtalker @JaySon-Huang @CalvinNeo @breezewish