Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine local tunnel #6463

Merged
merged 49 commits into from
Jan 10, 2023
Merged

Refine local tunnel #6463

merged 49 commits into from
Jan 10, 2023

Conversation

xzhangxian1008
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #6225

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • SeaRise
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 8, 2022
@xzhangxian1008
Copy link
Contributor Author

/cc @windtalker @gengliqi

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2022
@SeaRise SeaRise self-requested a review December 12, 2022 05:52
SeaRise
SeaRise reviewed Dec 12, 2022
View reviewed changes
dbms/src/Flash/Mpp/MPPTunnel.h Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/MPPTask.cpp Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/MPPTask.cpp Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/MPPTunnel.cpp Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/MPPTunnel.h Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/MPPHandler.cpp Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/MPPHandler.cpp Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/MPPTunnel.h Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/ExchangeReceiverCommon.h Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/ExchangeReceiver.cpp Outdated Show resolved Hide resolved
@xzhangxian1008
Copy link
Contributor Author

/run-all-tests

windtalker
windtalker reviewed Jan 4, 2023
View reviewed changes
dbms/src/Flash/Mpp/ExchangeReceiver.cpp Outdated
finishAllMsgChannels();
cv.notify_all();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not call cv.notify_all() in L758?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not call cv.notify_all() in L758?

OK, I think call it in L758 is better otherwise cv.notify_all() will be called unnecessarily when meet_error is true.

@SeaRise SeaRise self-requested a review January 4, 2023 03:29
SeaRise
SeaRise approved these changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@SeaRise SeaRise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM

dbms/src/Flash/Mpp/ReceiverChannelWriter.h Outdated Show resolved Hide resolved
dbms/src/Flash/Mpp/ReceiverChannelWriter.cpp Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 4, 2023
@xzhangxian1008
Copy link
Contributor Author

/run-all-tests

windtalker
windtalker approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 10, 2023
@ywqzzy
Copy link
Contributor

ywqzzy commented Jan 10, 2023

/merge

@ti-chi-bot
Copy link
Member

@ywqzzy: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1f087f3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 10, 2023
@xzhangxian1008
Copy link
Contributor Author

/run-unit-test

@xzhangxian1008
Copy link
Contributor Author

/run-integration-test

1 similar comment
@xzhangxian1008
Copy link
Contributor Author

/run-integration-test

@ti-chi-bot ti-chi-bot merged commit f9167f3 into pingcap:master Jan 10, 2023
@xzhangxian1008 xzhangxian1008 deleted the rf_local branch January 10, 2023 10:31
@xzhangxian1008 xzhangxian1008 restored the rf_local branch January 11, 2023 02:07
@xzhangxian1008 xzhangxian1008 deleted the rf_local branch January 11, 2023 06:51
@xzhangxian1008 xzhangxian1008 mentioned this pull request Jan 12, 2023
Merged
12 tasks
@solotzg solotzg mentioned this pull request Jan 13, 2023
Merged
12 tasks
solotzg added a commit to solotzg/tiflash that referenced this pull request Jan 13, 2023
@solotzg
Revert "Refine local tunnel (pingcap#6463)"
dceb065 
This reverts commit f9167f3.
solotzg added a commit to solotzg/tiflash that referenced this pull request Jan 18, 2023
@solotzg
Revert "Refine local tunnel (pingcap#6463)"
bf1db20 
This reverts commit f9167f3.

Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
solotzg added a commit to solotzg/tiflash that referenced this pull request Jan 30, 2023
@solotzg
Revert "Refine local tunnel (pingcap#6463)"
ac0c369 
This reverts commit f9167f3.

Signed-off-by: Zhigao Tong <tongzhigao@pingcap.com>
solotzg added a commit to solotzg/tiflash that referenced this pull request Feb 2, 2023
@solotzg
Revert "Refine local tunnel (pingcap#6463)"
f24973d 
This reverts commit f9167f3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yibin87 yibin87 yibin87 left review comments

@gengliqi gengliqi gengliqi left review comments

@windtalker windtalker windtalker approved these changes

@SeaRise SeaRise SeaRise approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@xzhangxian1008 @ti-chi-bot @SeaRise @ywqzzy @windtalker @yibin87 @gengliqi @guo-shaoge