Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

degrade to armv8.0 (#6255) #6256

Merged
merged 4 commits into from
Nov 7, 2022
Merged

degrade to armv8.0 (#6255) #6256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1087b3d
degrader to armv8.0
Lloyd-Pottiger Nov 6, 2022
b6debe1
use asimd default
Lloyd-Pottiger Nov 6, 2022
b824d8c
set COMPILER_FLAGS directly
Lloyd-Pottiger Nov 6, 2022
d2ff65a
fix fullstack-test
Lloyd-Pottiger Nov 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cmake/cpu_features.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,17 @@ if (ARCH_AARCH64)
# [1] https://en.wikipedia.org/wiki/AArch64
option (TIFLASH_ENABLE_ASIMD_SUPPORT "Enable Advanced SIMD support." ON)
option (TIFLASH_ENABLE_SVE_SUPPORT "Enable Scalable Vector Extension support." OFF)
option (NO_ARMV81_OR_HIGHER "Disable ARMv8.1 or higher on Aarch64 for maximum compatibility with older/embedded hardware." OFF)
# TODO: default ON, to be changed after CI is updated
option (NO_ARMV81_OR_HIGHER "Disable ARMv8.1 or higher on Aarch64 for maximum compatibility with older/embedded hardware." ON)

if (NO_ARMV81_OR_HIGHER)
# crc32 is optional in v8.0 and mandatory in v8.1. Enable it as __crc32()* is used in lot's of places and even very old ARM CPUs
# support it.
set (COMPILER_FLAGS "${COMPILER_FLAGS} -march=armv8+crc")
if (TIFLASH_ENABLE_ASIMD_SUPPORT)
set (COMPILER_FLAGS "${COMPILER_FLAGS}+simd")
add_definitions(-DTIFLASH_ENABLE_ASIMD_SUPPORT=1)
endif ()
else ()
# ARMv8.2 is quite ancient but the lowest common denominator supported by both Graviton 2 and 3 processors [1]. In particular, it
# includes LSE (made mandatory with ARMv8.1) which provides nice speedups without having to fall back to compat flag
Expand Down
4 changes: 2 additions & 2 deletions tests/fullstack-test2/ddl/alter_pk.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ mysql> alter table test.t drop primary key;
mysql> drop table if exists test.t_case;
## create table with `source` is nullable
## insert some data and left `source` to be empty
mysql> create table test.t_case (`case_no` varchar(32) not null,`source` varchar(20) default null,`p` varchar(12) DEFAULT NULL,primary key (`case_no`));
mysql> create table test.t_case (`case_no` varchar(32) not null,`source` varchar(20) default null,`p` varchar(12) DEFAULT NULL,primary key (`case_no`) NONCLUSTERED);
mysql> insert into test.t_case(case_no) values ("1"), ("2"), ("3"), ("4");

## drop the primary key, fill the `source` to be non-empty
Expand All @@ -88,7 +88,7 @@ mysql> select case_no,p,source from test.t_case;
# issue 5859, case 2
mysql> drop table if exists test.t_case;
## create table with `case_no`
mysql> create table test.t_case (`case_no` varchar(32) not null,`p` varchar(12) DEFAULT NULL,primary key (`case_no`));
mysql> create table test.t_case (`case_no` varchar(32) not null,`p` varchar(12) DEFAULT NULL,primary key (`case_no`) NONCLUSTERED);
mysql> insert into test.t_case(case_no) values ("1"), ("2"), ("3"), ("4");

mysql> alter table test.t_case add column `source` varchar(20) not null;
Expand Down