Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a panic issue in parallel agg when exception is thrown #5433

Merged
merged 2 commits into from
Jul 21, 2022
Merged

fix a panic issue in parallel agg when exception is thrown #5433

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80455a7
fix agg panic
gengliqi Jul 21, 2022
a32a616
Merge branch 'master' into agg-panic
gengliqi Jul 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions dbms/src/DataStreams/ParallelAggregatingBlockInputStream.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,10 +195,9 @@ void ParallelAggregatingBlockInputStream::Handler::onException(std::exception_pt
Int32 old_value = -1;
parent.first_exception_index.compare_exchange_strong(old_value, static_cast<Int32>(thread_num), std::memory_order_seq_cst, std::memory_order_relaxed);

/// can not cancel parent inputStream or the exception might be lost
if (!parent.executed)
/// use cancel instead of kill to avoid too many useless error message
parent.processor.cancel(false);
parent.cancel(false);
}


Expand Down