Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize comparision for collation UTF8_BIN and UTF8MB4_BIN (#5299) #5354

Merged
merged 1 commit into from
Jul 12, 2022
Merged

Optimize comparision for collation UTF8_BIN and UTF8MB4_BIN (#5299) #5354

merged 1 commit into from
Jul 12, 2022

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented Jul 12, 2022 •
edited
Loading

Issue Number: ref #5294
cherry-pick #5299

Release note

None

@solotzg solotzg requested a review from windtalker July 12, 2022 03:23
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 12, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • windtalker
  • yibin87

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 12, 2022
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 12, 2022
windtalker
windtalker approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 12, 2022
@windtalker
Copy link
Contributor

/rebuild

1 similar comment
@solotzg
Copy link
Contributor Author

solotzg commented Jul 12, 2022

/rebuild

yibin87
yibin87 approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 12, 2022
@windtalker windtalker merged commit 0b41f97 into pingcap:release-6.1-20220712 Jul 12, 2022
@solotzg solotzg deleted the release-6.1-20220712 branch July 14, 2022 02:02
@solotzg solotzg added type/enhancement The issue or PR belongs to an enhancement. type/performance labels Jul 15, 2022
@jayl1e jayl1e added this to the v6.1.1 milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@yibin87 yibin87 yibin87 approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement. type/performance
Projects
None yet
Milestone
v6.1.1
Development

Successfully merging this pull request may close these issues.
6 participants
@solotzg @ti-chi-bot @windtalker @yibin87 @jayl1e @sre-bot