*: Add some comments about decoding #5158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
JaySon-Huang
force-pushed
the
comments_decoding
branch
from
e8c8bc6
to
70df8f2
Compare
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
JaySon-Huang
force-pushed
the
comments_decoding
branch
from
70df8f2
to
dfe31a2
Compare
|
/run-all-tests |
|
@JaySon-Huang: GitHub didn't allow me to request PR reviews from the following users: hongyunyan. Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
LGTM |
breezewish
approved these changes
Jun 17, 2022
ti-chi-bot
added
status/LGT2
|
/merge |
|
@breezewish: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: dfe31a2
|
ti-chi-bot
added
the
status/can-merge
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
|
/run-integration-test |
1 similar comment
|
/run-integration-test |
Signed-off-by: JaySon-Huang <jayson.hjs@gmail.com>
ti-chi-bot
removed
the
status/can-merge
|
/merge |
|
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: bfc5cd6
|
ti-chi-bot
added
the
status/can-merge
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
ti-chi-bot
removed
the
status/can-merge
|
/run-all-tests |
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
JaySon-Huang
commented
Jun 18, 2022
| @@ -21,6 +21,7 @@ mysql> insert into test.t values(1,'a'),(2,'b'),(3,'c') | |||
| mysql> alter table test.t set tiflash replica 1 | |||
|
|
|||
| func> wait_table test t | |||
| mysql> analyze table test.t | |||
There was a problem hiding this comment.
Add this line to fix the error caused by tidb execute plan change
[2022-06-17T17:32:18.320Z] File: fullstack-test/mpp/mpp_fail.test
[2022-06-17T17:32:18.320Z] Error line: 30
[2022-06-17T17:32:18.320Z] Error: use test; set @@tidb_isolation_read_engines='tiflash'; set @@tidb_allow_mpp=1; select count(value), id from t group by id;
[2022-06-17T17:32:18.320Z] Result:
[2022-06-17T17:32:18.320Z] count(value) id
[2022-06-17T17:32:18.320Z] 1 2
[2022-06-17T17:32:18.320Z] 1 3
[2022-06-17T17:32:18.320Z] 1 1
[2022-06-17T17:32:18.320Z] Expected:
[2022-06-17T17:32:18.320Z] ERROR 1105 (HY000) at line 1: DB::Exception: Fail point FailPoints::exception_before_mpp_register_non_root_mpp_task is triggered.
|
/merge |
|
@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 64d1213
|
ti-chi-bot
added
the
status/can-merge
Coverage for changed filesCoverage summaryfull coverage report (for internal network access only) |
SeaRise
added a commit
to SeaRise/tiflash
that referenced
this pull request
Jun 21, 2022
12 tasks
SeaRise
added a commit
to SeaRise/tiflash
that referenced
this pull request
Jun 22, 2022
fmt revert fix executor test format fix tests fix ut fix projection bug format update revert useless change fix test from pingcap#5158 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JaySon-Huang jayson.hjs@gmail.com
What problem does this PR solve?
Issue Number: ref #4862
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note