PageStorage: Fix pages are not deleted under some cases

[JaySon-Huang]

What problem does this PR solve?

Issue Number: close #5054

Problem Summary: as the issue described. V2.data.getAliveExternalPageIds returns the dtfile ids after deleted, so the deleted dtfiles can not be removed from disk. Restart the TiFlash process can workaround the issue as the page ids are deleted when restored from v2 wal.

What is changed and how it works?

• StoragePool only need to remove DTFiles ids that are not exist in the V3.data, cause we perform force transform from V2.data to V3.data when restore
• Keep tombstone when merging the delta version for page entries in V2, or the page id will shown in getAliveExternalPageIds after deleted

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

• Manual test steps:
  • Deploy cluster and load some data into TiFlash with storage.format_version = 3
  • Change the storage.format_version = 4
  • Use alter table t compact tiflash replica to perform delta-merge
  • Check that the old DTFiles are removed

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• flowbehappy
• hehechen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[JaySon-Huang]

/run-all-tests

[sre-bot]

Coverage for changed files

Filename                                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DeltaMerge/StoragePool.cpp                            223                98    56.05%          30                 8    73.33%         478               187    60.88%         146                78    46.58%
Page/Page.h                                            61                 6    90.16%          15                 1    93.33%          80                17    78.75%          38                12    68.42%
Page/V2/PageEntries.h                                 128                14    89.06%          49                11    77.55%         300                54    82.00%          64                 5    92.19%
Page/V3/tests/gtest_page_storage_mix_mode.cpp        2854               765    73.20%          22                 0   100.00%         832                21    97.48%         820               422    48.54%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                3266               883    72.96%         116                20    82.76%        1690               279    83.49%        1068               517    51.59%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18282      9732             46.77%    205081  97591        52.41%

full coverage report (for internal network access only)

[JaySon-Huang]

/merge

[ti-chi-bot]

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 68e5d85

[sre-bot]

Coverage for changed files

Filename                                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DeltaMerge/StoragePool.cpp                            223                98    56.05%          30                 8    73.33%         478               187    60.88%         146                78    46.58%
Page/Page.h                                            61                 6    90.16%          15                 1    93.33%          80                17    78.75%          38                12    68.42%
Page/V2/PageEntries.h                                 128                14    89.06%          49                11    77.55%         300                54    82.00%          64                 5    92.19%
Page/V3/tests/gtest_page_storage_mix_mode.cpp        2854               765    73.20%          22                 0   100.00%         832                21    97.48%         820               422    48.54%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                3266               883    72.96%         116                20    82.76%        1690               279    83.49%        1068               517    51.59%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18282      9732             46.77%    205081  97591        52.41%

full coverage report (for internal network access only)

[ti-chi-bot]

In response to a cherrypick label: new pull request created: #5071.

[sre-bot]

Coverage for changed files

Filename                                          Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DeltaMerge/StoragePool.cpp                            223                98    56.05%          30                 8    73.33%         478               187    60.88%         146                78    46.58%
Page/Page.h                                            61                 6    90.16%          15                 1    93.33%          80                17    78.75%          38                12    68.42%
Page/V2/PageEntries.h                                 128                14    89.06%          49                11    77.55%         300                54    82.00%          64                 5    92.19%
Page/V3/tests/gtest_page_storage_mix_mode.cpp        2854               765    73.20%          22                 0   100.00%         832                21    97.48%         820               422    48.54%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                3266               883    72.96%         116                20    82.76%        1690               279    83.49%        1068               517    51.59%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18282      9732             46.77%    205081  97618        52.40%

full coverage report (for internal network access only)