Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pageutils will truncate the file if write failed #4925

Merged
merged 13 commits into from
May 19, 2022
Merged

Fix pageutils will truncate the file if write failed #4925

Changes from 2 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2b5aac6
Fix pageutils will truncate the file if write failed
jiaqizho May 18, 2022
bfb6735
update
jiaqizho May 18, 2022
f99eec1
change to arg
jiaqizho May 18, 2022
e2f8a7f
add note
jiaqizho May 18, 2022
fba6d31
add todo
jiaqizho May 18, 2022
596cf64
Merge remote-tracking branch 'upstream/master' into fix-pageutil-trun…
JaySon-Huang May 18, 2022
254e351
Add more log for error
JaySon-Huang May 18, 2022
7bd0f51
Merge branch 'master' into fix-pageutil-truncate
ti-chi-bot May 18, 2022
350f337
Merge branch 'master' into fix-pageutil-truncate
ti-chi-bot May 18, 2022
f7c8d8a
Fix ut
JaySon-Huang May 18, 2022
4ed52a9
Fix lint
JaySon-Huang May 18, 2022
5167571
Merge branch 'master' into fix-pageutil-truncate
ti-chi-bot May 18, 2022
19ecafd
Merge branch 'master' into fix-pageutil-truncate
ti-chi-bot May 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions dbms/src/Storages/Page/PageUtil.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,15 +192,10 @@ void writeFile(
{
ProfileEvents::increment(ProfileEvents::PSMWriteFailed);
auto saved_errno = errno;
// If error occurs, apply `ftruncate` try to truncate the broken bytes we have written.
// Note that the result of this ftruncate is ignored, there is nothing we can do to
// handle ftruncate error. The errno may change after ftruncate called.
int truncate_res = ::ftruncate(file->getFd(), offset);

DB::throwFromErrno(fmt::format("Cannot write to file {},[truncate_res = {}],[errno_after_truncate = {}],"
DB::throwFromErrno(fmt::format("Cannot write to file {},[errno_after_truncate = {}],"
"[bytes_written={},to_write={},offset = {}]",
file->getFileName(),
truncate_res,
strerror(errno),
bytes_written,
to_write,
Expand Down