Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: Add comments #4863

Merged
merged 7 commits into from
May 13, 2022
Merged

misc: Add comments #4863

merged 7 commits into from
May 13, 2022

Conversation

breezewish
Copy link
Member

What problem does this PR solve?

Issue Number: ref #4862

What is changed and how it works?

Added some comments when I go through the DeltaTree write path.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 11, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 11, 2022
@breezewish breezewish requested review from lidezhu and JaySon-Huang and removed request for lidezhu May 11, 2022 09:02
dbms/src/Storages/IManageableStorage.h Outdated Show resolved Hide resolved
dbms/src/Storages/IManageableStorage.h Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2022
Copy link
Contributor

@lidezhu lidezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 13, 2022
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 13, 2022
@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e40485d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented May 13, 2022

Coverage for changed files

Filename                                   Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
DeltaMerge/ColumnFile/ColumnFile.h              19                 5    73.68%          19                 5    73.68%          23                 9    60.87%           0                 0         -
DeltaMerge/ColumnFile/ColumnFileTiny.h          24                 7    70.83%          15                 1    93.33%          36                 8    77.78%           6                 4    33.33%
DeltaMerge/Delta/DeltaValueSpace.h             107                22    79.44%          48                 4    91.67%         121                23    80.99%          36                13    63.89%
DeltaMerge/Delta/MemTableSet.cpp               119                24    79.83%           9                 0   100.00%         196                14    92.86%          96                25    73.96%
DeltaMerge/Delta/MemTableSet.h                   7                 0   100.00%           6                 0   100.00%          20                 0   100.00%           2                 0   100.00%
DeltaMerge/DeltaMergeHelpers.h                  91                 7    92.31%          21                 0   100.00%         167                 8    95.21%          56                10    82.14%
DeltaMerge/DeltaMergeStore.cpp                1392               464    66.67%          66                 5    92.42%        1981               436    77.99%         808               364    54.95%
DeltaMerge/DeltaMergeStore.h                    41                13    68.29%          19                 2    89.47%          91                30    67.03%          42                11    73.81%
DeltaMerge/RowKeyRange.h                       261                53    79.69%          63                13    79.37%         501                99    80.24%         166                48    71.08%
DeltaMerge/Segment.h                            34                 5    85.29%          22                 3    86.36%          31                 4    87.10%           6                 3    50.00%
IManageableStorage.h                            22                20     9.09%          22                20     9.09%          40                38     5.00%           0                 0         -
StorageDeltaMerge.cpp                          678               359    47.05%          57                27    52.63%        1303               758    41.83%         378               260    31.22%
StorageDeltaMerge.h                             11                 7    36.36%          11                 7    36.36%          17                 9    47.06%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                         2806               986    64.86%         378                87    76.98%        4527              1436    68.28%        1596               738    53.76%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
18121      9785             46.00%    202195  97855        51.60%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 8bb0622 into master May 13, 2022
@breezewish breezewish deleted the wenxuan/doccomments branch May 13, 2022 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants