-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PageStorage: Add mix mode #4726
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
/run-all-tests |
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
pre PR : #4736 |
Signed-off-by: jiaqizho <zhoujiaqi@pingcap.com>
PTAL at https://github.com/jiaqizho/tiflash/pull/11. |
hide lots of switch by inherite
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
@@ -178,7 +178,7 @@ class DeltaMergeStoreRWTest | |||
return s; | |||
} | |||
|
|||
std::pair<RowKeyRange, std::vector<PageId>> genDMFile(DMContext & context, const Block & block) | |||
std::pair<RowKeyRange, PageIds> genDMFile(DMContext & context, const Block & block) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add UT to test delta merge storage in mix mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to add it in the follow-up PR. Cause writing ut with GlobalPathPool
is not easy.
otherwise, already have test cover in V3/gtest_page_storage_mix_mode.cpp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: d2a6ae0
|
@jiaqizho: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Coverage for changed files
Coverage summary
full coverage report (for internal network access only) |
Signed-off-by: jiaqizho zhoujiaqi@pingcap.com
What problem does this PR solve?
Issue Number: ref #3594
Problem Summary:
What is changed and how it works?
Mix Mode
. Which will both deal with V3 and V2 format data.$DATA_DIR/kvstore
for kvstore (PageStorage V2/V1)$DATA_DIR/page/kvstore
for kvstore (PageStorage V3)storage.raft.dir
/raft.kvstore_path
will be ignoredCheck List
Tests
Side effects
Documentation
Release note