Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Fix memory leak when MPMCQueue destruct with non-poped elements #4221

Merged
merged 4 commits into from
Mar 11, 2022
Merged

*: Fix memory leak when MPMCQueue destruct with non-poped elements #4221

merged 4 commits into from
Mar 11, 2022

Conversation

fuzhe1989
Copy link
Contributor

Signed-off-by: fuzhe1989 fuzhe1989@gmail.com

What problem does this PR solve?

Issue Number: close #4098

Problem Summary:

MPMCQueue forgot to destruct non-poped elements when destructing.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix memory leak when a query is cancelled.

@fuzhe1989
update
a149119 
Signed-off-by: fuzhe1989 <fuzhe1989@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 11, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bestwoody
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 11, 2022
@fuzhe1989
update
8e17f3a 
Signed-off-by: fuzhe1989 <fuzhe1989@gmail.com>
windtalker
windtalker approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 11, 2022
bestwoody
bestwoody approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@bestwoody bestwoody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 11, 2022
@fuzhe1989
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8e17f3a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 11, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 11, 2022

Coverage for changed files

Filename                       Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
MPMCQueue.h                         76                 0   100.00%          29                 0   100.00%         166                 1    99.40%          44                 2    95.45%
tests/gtest_mpmc_queue.cpp        1424               292    79.49%          45                 0   100.00%         514                12    97.67%         480               218    54.58%
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             1500               292    80.53%          74                 0   100.00%         680                13    98.09%         524               220    58.02%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16781      9447             43.70%    188938  95727        49.33%

full coverage report (for internal network access only)

@ti-chi-bot
Copy link
Member

@fuzhe1989: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@fuzhe1989
Copy link
Contributor Author

/rebuild

@fuzhe1989
Copy link
Contributor Author

/run-all-tests

@fuzhe1989
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 11, 2022

Coverage for changed files

no c/c++ source change detected

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16785      9444             43.74%    189106  95737        49.37%

full coverage report (for internal network access only)

@SchrodingerZhu
Copy link
Contributor

/build

1 similar comment
@SchrodingerZhu
Copy link
Contributor

/build

@ti-chi-bot ti-chi-bot merged commit f50e1a9 into pingcap:master Mar 11, 2022
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Mar 11, 2022
@fuzhe1989 @ti-chi-bot
This is an automated cherry-pick of pingcap#4221
2009e83 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 11, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4230.

@fuzhe1989 fuzhe1989 deleted the fuzhe/fix_mpmc_queue_leak branch March 11, 2022 14:10
ti-chi-bot added a commit that referenced this pull request Apr 22, 2022
@ti-chi-bot
*: Fix memory leak when MPMCQueue destruct with non-poped elements (#…
08e993f 
…4221) (#4230)

close #4098
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bestwoody bestwoody bestwoody approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

killing mpp query raise tiflash oom when enable_elastic_threadpool
6 participants
@fuzhe1989 @ti-chi-bot @sre-bot @SchrodingerZhu @windtalker @bestwoody