Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the bug that canceled MPP query may cause tasks hang forever when local tunnel is enabled. #4219

Merged
merged 8 commits into from
Mar 11, 2022
Merged

Fix the bug that canceled MPP query may cause tasks hang forever when local tunnel is enabled. #4219

merged 8 commits into from
Mar 11, 2022

Conversation

bestwoody
Copy link
Contributor

@bestwoody bestwoody commented Mar 10, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #4229

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Fix the bug that canceled MPP query may cause tasks hang forever when local tunnel is enabled.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 10, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fuzhe1989
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2022
windtalker
windtalker approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 10, 2022
@fzhedu
Copy link
Contributor

fzhedu commented Mar 10, 2022

add test case using fail point?

@bestwoody
Copy link
Contributor Author

bestwoody commented Mar 10, 2022 •
edited
Loading

add test case using fail point?

how to? Any suggestion?

@fzhedu
Copy link
Contributor

fzhedu commented Mar 10, 2022

add test case using fail point?

how to? Any suggestion?

you can refer to https://github.com/pingcap/tics/pull/1533/files

@fuzhe1989
Copy link
Contributor

need release note

@fuzhe1989
Copy link
Contributor

suggestions:

  1. create a bug.
  2. refine the title.
  3. say something in the release note.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Mar 11, 2022
@bestwoody bestwoody changed the title fix a bug which causes recevie not be canceled fix a bug which causes ExchangeReceiver not be canceled Mar 11, 2022
@bestwoody
Copy link
Contributor Author

bestwoody commented Mar 11, 2022 •
edited
Loading

add test case using fail point?

how to? Any suggestion?

you can refer to https://github.com/pingcap/tics/pull/1533/files

Thanks for your reference. But, that is a test for query handle. Cancel didn't hang the query. How can I use that to test the query thread exit?

@bestwoody
Copy link
Contributor Author

bestwoody commented Mar 11, 2022 •
edited
Loading

That is a test for query handle. However cancel didn't hang the query. How can I use that to test the query thread exit?

  1. got it, done
    2.done
    3.done

@fuzhe1989
Copy link
Contributor

suggestion to release-note: "Fix bug that cancel MPP query may cause tasks hang forever when enable local tunnel."

@bestwoody bestwoody changed the title fix a bug which causes ExchangeReceiver not be canceled Fix the bug that canceled MPP query may cause tasks hang forever when local tunnel is enabled. Mar 11, 2022
@bestwoody bestwoody changed the title Fix the bug that canceled MPP query may cause tasks hang forever when local tunnel is enabled. Fix a bug that canceled MPP query may cause tasks hang forever when local tunnel is enabled. Mar 11, 2022
@bestwoody bestwoody changed the title Fix a bug that canceled MPP query may cause tasks hang forever when local tunnel is enabled. Fix the bug that canceled MPP query may cause tasks hang forever when local tunnel is enabled. Mar 11, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. and removed status/LGT1 Indicates that a PR has LGTM 1. do-not-merge/needs-triage-completed labels Mar 11, 2022
@fuzhe1989
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8e6beaf

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 11, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 11, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16820      9444             43.85%    189214  95756        49.39%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 11, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16842      9446             43.91%    189536  95800        49.46%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 0fe0b40 into pingcap:master Mar 11, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 11, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4236.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 11, 2022
Merged
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4237.

@JaySon-Huang JaySon-Huang deleted the bugfix_highend branch March 12, 2022 04:54
@bestwoody bestwoody mentioned this pull request Apr 14, 2022
Merged
12 tasks
ti-chi-bot added a commit that referenced this pull request Apr 14, 2022
@ti-chi-bot
Fix the bug that canceled MPP query may cause tasks hang forever when…
ebbd9cc 
… local tunnel is enabled. (#4219) (#4237)

close #4229
ti-chi-bot added a commit that referenced this pull request Apr 14, 2022
@ti-chi-bot
Fix the bug that canceled MPP query may cause tasks hang forever when…
f013d89 
… local tunnel is enabled. (#4219) (#4236)

close #4229
@windtalker windtalker mentioned this pull request Jun 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@fuzhe1989 fuzhe1989 fuzhe1989 approved these changes

@fzhedu fzhedu Awaiting requested review from fzhedu

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some exchange tasks can't exit when query is canceled
6 participants
@bestwoody @ti-chi-bot @fzhedu @fuzhe1989 @sre-bot @windtalker