Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expr: support IsTrue/IsTrueWithNull/IsFalse/IsFalseWithNull #4184

Merged
merged 5 commits into from
Mar 8, 2022

Conversation

fuzhe1989
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #1863

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Support IsTrue, IsTrueWithNull, IsFalse, IsFalseWithNull on TiFlash.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 6, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • yibin87

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 6, 2022
@fuzhe1989
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 6, 2022

Coverage for changed files

Filename                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Coprocessor/DAGUtils.cpp                  285               228    20.00%          35                23    34.29%         491               390    20.57%         320               226    29.38%
Functions/FunctionsComparison.cpp                 8                 7    12.50%           8                 7    12.50%          42                29    30.95%           0                 0         -
Functions/FunctionsComparison.h                 588               446    24.15%          62                37    40.32%         920               653    29.02%         466               372    20.17%
Functions/tests/gtest_is_true_false.cpp        1433               395    72.44%          12                 0   100.00%         166                 0   100.00%         418               221    47.13%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                          2314              1076    53.50%         117                67    42.74%        1619              1072    33.79%        1204               819    31.98%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16725      9456             43.46%    187445  95548        49.03%

full coverage report (for internal network access only)

Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 7, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 8, 2022
@fuzhe1989
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c897bb1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 8, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 8, 2022

Coverage for changed files

Filename                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Coprocessor/DAGUtils.cpp                  290               233    19.66%          36                24    33.33%         505               404    20.00%         324               230    29.01%
Functions/FunctionsComparison.cpp                 8                 7    12.50%           8                 7    12.50%          42                29    30.95%           0                 0         -
Functions/FunctionsComparison.h                 588               446    24.15%          62                37    40.32%         920               653    29.02%         466               372    20.17%
Functions/tests/gtest_is_true_false.cpp        1433               395    72.44%          12                 0   100.00%         166                 0   100.00%         418               221    47.13%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                          2319              1081    53.39%         118                68    42.37%        1633              1086    33.50%        1208               823    31.87%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16777      9447             43.69%    188895  95724        49.32%

full coverage report (for internal network access only)

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 8, 2022

Coverage for changed files

Filename                                    Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Coprocessor/DAGUtils.cpp                  290               233    19.66%          36                24    33.33%         505               404    20.00%         324               230    29.01%
Functions/FunctionsComparison.cpp                 8                 7    12.50%           8                 7    12.50%          42                29    30.95%           0                 0         -
Functions/FunctionsComparison.h                 588               446    24.15%          62                37    40.32%         920               653    29.02%         466               372    20.17%
Functions/tests/gtest_is_true_false.cpp        1433               395    72.44%          12                 0   100.00%         166                 0   100.00%         418               221    47.13%
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                          2319              1081    53.39%         118                68    42.37%        1633              1086    33.50%        1208               823    31.87%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16777      9447             43.69%    188895  95700        49.34%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 9084756 into pingcap:master Mar 8, 2022
@JaySon-Huang JaySon-Huang deleted the fuzhe/is_true_false branch March 8, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support IsTrueWithNull, IsTrue and IsFalseWithNull, IsFalse in TiFlash
5 participants