Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PageStorage: Fix BlobStore read with FieldReadInfos #4181

Merged
merged 5 commits into from
Mar 7, 2022
Merged

PageStorage: Fix BlobStore read with FieldReadInfos #4181

merged 5 commits into from
Mar 7, 2022

Conversation

JaySon-Huang
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #3594

Problem Summary:

  • BlobStore::read(FieldReadInfos & to_read, ... doesn't respect the info in to_read, the page.field_offsets in result is empty.
  • BlobStore::read(const PageIDAndEntryV3 & id_entry, ... doesn't check the checksum of read data
  • Fix some dm_stress issue

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 4, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JinheLin
  • jiaqizho

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 4, 2022
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 4, 2022

Coverage for changed files

Filename                                        Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/Exception.cpp                                 78                65    16.67%          13                10    23.08%         160               120    25.00%          30                27    10.00%
Storages/Page/Page.h                                 53                 5    90.57%          12                 0   100.00%          58                 7    87.93%          34                12    64.71%
Storages/Page/V3/BlobStore.cpp                      352               106    69.89%          39                 3    92.31%         769               197    74.38%         216                80    62.96%
Storages/Page/V3/PageEntry.h                          8                 2    75.00%           2                 1    50.00%          13                 6    53.85%           4                 1    75.00%
Storages/Page/V3/tests/gtest_blob_store.cpp        3549               584    83.54%          17                 0   100.00%         729                 0   100.00%        1102               518    52.99%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                              4040               762    81.14%          83                14    83.13%        1729               330    80.91%        1386               638    53.97%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16705      9452             43.42%    187254  95531        48.98%

full coverage report (for internal network access only)

jiaqizho
jiaqizho approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@jiaqizho jiaqizho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 7, 2022
@JinheLin
Copy link
Contributor

JinheLin commented Mar 7, 2022

LGTM

But I think the dm_stress tool can be deprecated and remove from the source code soon. For test DeltaTree, you can use tiflash --dtworkload or ./tiflash --dtworkload --help.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 7, 2022
@JaySon-Huang
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 26d0b3c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 7, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 7, 2022

Coverage for changed files

Filename                                        Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Common/Exception.cpp                                 78                65    16.67%          13                10    23.08%         160               120    25.00%          30                27    10.00%
Storages/Page/Page.h                                 53                 5    90.57%          12                 0   100.00%          58                 7    87.93%          34                12    64.71%
Storages/Page/V3/BlobStore.cpp                      352               106    69.89%          39                 3    92.31%         769               197    74.38%         216                80    62.96%
Storages/Page/V3/PageEntry.h                          8                 2    75.00%           2                 1    50.00%          13                 6    53.85%           4                 1    75.00%
Storages/Page/V3/tests/gtest_blob_store.cpp        3549               584    83.54%          17                 0   100.00%         729                 0   100.00%        1102               518    52.99%
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                              4040               762    81.14%          83                14    83.13%        1729               330    80.91%        1386               638    53.97%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16705      9452             43.42%    187277  95557        48.98%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 7c1a78e into pingcap:master Mar 7, 2022
@JaySon-Huang JaySon-Huang deleted the fix_blob_read branch March 7, 2022 04:55
@JaySon-Huang JaySon-Huang mentioned this pull request Mar 14, 2022
Closed
76 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JinheLin JinheLin JinheLin approved these changes

@jiaqizho jiaqizho jiaqizho approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JaySon-Huang @ti-chi-bot @sre-bot @JinheLin @jiaqizho