Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add namespace id to PageStorage interface #4175

Merged
merged 21 commits into from
Mar 11, 2022
Merged

Add namespace id to PageStorage interface #4175

merged 21 commits into from
Mar 11, 2022

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Mar 3, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #3594

Problem Summary: add namespace id to PageStorage interface to support share single PageStorage instance accross different tables.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 3, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • jiaqizho

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 3, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 3, 2022

/rebuild

@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 3, 2022

/run-all-tests

1 similar comment
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 3, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 3, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16698      9463             43.33%    186901  95663        48.82%

full coverage report (for internal network access only)

@lidezhu lidezhu force-pushed the add-table-id-to-ps-interface branch from 91cc496 to c0f261d Compare March 3, 2022 12:31
@lidezhu
add namespace id to PageStorage interface
601e8a5 
Signed-off-by: lidezhu <lidezhu@pingcap.com>
@lidezhu lidezhu force-pushed the add-table-id-to-ps-interface branch from c0f261d to 601e8a5 Compare March 3, 2022 12:32
@lidezhu lidezhu requested review from JaySon-Huang and jiaqizho and removed request for jiaqizho March 3, 2022 12:34
jiaqizho
jiaqizho reviewed Mar 4, 2022
View reviewed changes
dbms/src/Storages/Page/V3/PageEntry.h Outdated Show resolved Hide resolved
dbms/src/Storages/Page/V3/PageEntry.h Outdated Show resolved Hide resolved
dbms/src/Storages/Page/WriteBatch.h Show resolved Hide resolved
@lidezhu
remove table_id from DMContext and put it into StoragePool
4bd63ee 
Signed-off-by: lidezhu <lidezhu@pingcap.com>
@lidezhu lidezhu force-pushed the add-table-id-to-ps-interface branch from 81a1176 to 4bd63ee Compare March 4, 2022 06:40
@lidezhu lidezhu changed the title Add namespace id to PageStorage interface [WIP] Add namespace id to PageStorage interface Mar 4, 2022
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2022
@lidezhu lidezhu changed the title [WIP] Add namespace id to PageStorage interface Add namespace id to PageStorage interface Mar 4, 2022
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2022
@lidezhu
fix conflict
1382948 
Signed-off-by: lidezhu <lidezhu@pingcap.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2022
@JaySon-Huang
Copy link
Contributor

/run-all-tests

jiaqizho
jiaqizho approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@jiaqizho jiaqizho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 10, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 10, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 10, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16785      9447             43.72%    188699  95715        49.28%

full coverage report (for internal network access only)

JaySon-Huang
JaySon-Huang approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a not important comment

dbms/src/Storages/Page/V3/PageEntry.h Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 10, 2022
@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 10, 2022

/run-all-tests

@lidezhu
Copy link
Contributor Author

lidezhu commented Mar 10, 2022

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 10, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16807      9446             43.80%    188991  95742        49.34%

full coverage report (for internal network access only)

@SchrodingerZhu
Copy link
Contributor

https://ci.pingcap.net/blue/organizations/jenkins/tiflash-build-common/detail/tiflash-build-common/30/pipeline

@JaySon-Huang
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9a3fe08

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 11, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 11, 2022

Coverage for changed files

too many lines from llvm-cov, please refer to full report instead

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16820      9444             43.85%    189213  95754        49.39%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 5f912af into pingcap:master Mar 11, 2022
@JaySon-Huang JaySon-Huang deleted the add-table-id-to-ps-interface branch March 12, 2022 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@jiaqizho jiaqizho jiaqizho approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lidezhu @ti-chi-bot @sre-bot @JaySon-Huang @SchrodingerZhu @jiaqizho