Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add space_map into PageStorage V3 #3493

Merged
merged 41 commits into from
Dec 9, 2021
Merged

Add space_map into PageStorage V3 #3493

merged 41 commits into from
Dec 9, 2021

Conversation

jiaqizho
Copy link
Contributor

@jiaqizho jiaqizho commented Nov 22, 2021

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and how it works?

Proposal:

What's Changed:

  • split from [POC]New page storage  #3197
  • now, space_map support free location
    • it can split range when calling the mark method with a no nearby block.
    • it can merge range when unmark the range with a nearby block.
  • Added some cmake as PageStorage V3 beginning.
  • Added some gtests for space_map.

Similar scope mergers have not yet been done. For this, there will create a new PR in the future.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 22, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 22, 2021
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 22, 2021
@ti-chi-bot ti-chi-bot requested review from ilovesoup and solotzg and removed request for ilovesoup and solotzg November 23, 2021 05:07
@JaySon-Huang JaySon-Huang changed the title Add space_map into PageStorage V3 [WIP] Add space_map into PageStorage V3 Nov 29, 2021
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2021
JaySon-Huang and others added 4 commits November 29, 2021 18:22
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
@jiaqizho jiaqizho changed the title [WIP] Add space_map into PageStorage V3 Add space_map into PageStorage V3 Dec 6, 2021
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2021
@jiaqizho
Copy link
Contributor Author

jiaqizho commented Dec 6, 2021

/run-all-tests

@sre-bot
Copy link
Collaborator

sre-bot commented Dec 6, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/258/cobertura/
(Coverage detail url is limited office network access)

lines: 37.6% (44765 out of 119179)
branches: 5.5% (67446 out of 1217007)

Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
@sre-bot
Copy link
Collaborator

sre-bot commented Dec 8, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/292/cobertura/
(Coverage detail url is limited office network access)

lines: 41.0% (45541 out of 111197)
branches: 5.7% (68562 out of 1201804)

Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out the changes in https://github.com/jiaqizho/tics/pull/5 and resolve the below comments.

The line coverage for files under spacemap is only 67%. I hope it can be greater than 80% before merging. https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/292/cobertura/dbms_src_Storages_Page_V3_spacemap/

dbms/src/Storages/Page/V3/spacemap/SpaceMapSTDMap.h Outdated Show resolved Hide resolved
dbms/src/Storages/Page/V3/spacemap/SpaceMapSTDMap.h Outdated Show resolved Hide resolved
dbms/src/Storages/Page/V3/spacemap/SpaceMapSTDMap.h Outdated Show resolved Hide resolved
dbms/src/Storages/Page/V3/spacemap/SpaceMapRBTree.cpp Outdated Show resolved Hide resolved
@pingcap pingcap deleted a comment from sre-bot Dec 9, 2021
@jiaqizho
Copy link
Contributor Author

jiaqizho commented Dec 9, 2021

/run-unit-test

@sre-bot
Copy link
Collaborator

sre-bot commented Dec 9, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/298/cobertura/
(Coverage detail url is limited office network access)

lines: 41.1% (45729 out of 111243)
branches: 5.7% (68776 out of 1202106)

Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the comments

dbms/src/Storages/Page/V3/spacemap/SpaceMap.h Outdated Show resolved Hide resolved
dbms/src/Storages/Page/V3/spacemap/SpaceMap.h Outdated Show resolved Hide resolved
dbms/src/Storages/Page/V3/spacemap/SpaceMap.h Outdated Show resolved Hide resolved
dbms/src/Storages/Page/V3/spacemap/SpaceMap.h Outdated Show resolved Hide resolved
Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: JaySon <jayson.hjs@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 9, 2021
jiaqizho and others added 3 commits December 9, 2021 11:22
Co-authored-by: JaySon <jayson.hjs@gmail.com>
Co-authored-by: JaySon <jayson.hjs@gmail.com>
Co-authored-by: JaySon <jayson.hjs@gmail.com>
@jiaqizho
Copy link
Contributor Author

jiaqizho commented Dec 9, 2021

/merge

@ti-chi-bot
Copy link
Member

@jiaqizho: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 00bf672

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 9, 2021
@sre-bot
Copy link
Collaborator

sre-bot commented Dec 9, 2021

Coverage detail: https://ci-internal.pingcap.net/job/tics_ghpr_unit_test/299/cobertura/
(Coverage detail url is limited office network access)

lines: 41.0% (45652 out of 111243)
branches: 5.7% (68706 out of 1202106)

@ti-chi-bot ti-chi-bot merged commit 4dc0526 into pingcap:master Dec 9, 2021
@JaySon-Huang JaySon-Huang deleted the add-space-map branch December 9, 2021 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants