fix clang_tidy

dbms/src/Common/RadixSort.h

@@ -28,12 +28,12 @@
   */
 struct RadixSortMallocAllocator
 {
-    void * allocate(size_t size)
+    static void * allocate(size_t size)
     {
         return malloc(size);
     }
 
-    void deallocate(void * ptr, size_t /*size*/)
+    static void deallocate(void * ptr, size_t /*size*/)
     {
         return free(ptr);
     }

dbms/src/Common/RecycledAllocator.h

@@ -8,7 +8,7 @@ namespace DB
 class RecycledAllocator : public boost::noncopyable
 {
 public:
-    RecycledAllocator(const size_t initial_size = 65536, const size_t growth_factor = 2)
+    explicit RecycledAllocator(const size_t initial_size = 65536, const size_t growth_factor = 2)
         : arena(initial_size, growth_factor)
     {}
 
@@ -25,4 +25,4 @@ class RecycledAllocator : public boost::noncopyable
     ArenaWithFreeLists arena;
 };
 
-} // namespace DB
+} // namespace DB

dbms/src/Common/RedactHelpers.cpp

@@ -14,7 +14,7 @@ void Redact::setRedactLog(bool v)
     Redact::REDACT_LOG.store(v, std::memory_order_relaxed);
 }
 
-std::string Redact::handleToDebugString(const DB::HandleID handle)
+std::string Redact::handleToDebugString(DB::HandleID handle)
 {
     if (Redact::REDACT_LOG.load(std::memory_order_relaxed))
         return "?";
@@ -30,7 +30,7 @@ std::string Redact::keyToHexString(const char * key, size_t size)
     char * pos = buf.data();
     for (size_t i = 0; i < size; ++i)
     {
-        writeHexByteUppercase((UInt8)(key[i]), pos);
+        writeHexByteUppercase(static_cast<UInt8>(key[i]), pos);
         pos += 2;
     }
     return buf;

dbms/src/Common/RedactHelpers.h

@@ -15,7 +15,7 @@ class Redact
 public:
     static void setRedactLog(bool v);
 
-    static std::string handleToDebugString(const DB::HandleID handle);
+    static std::string handleToDebugString(DB::HandleID handle);
     static std::string keyToDebugString(const char * key, size_t size);
 
     static std::string keyToHexString(const char * key, size_t size);
@@ -25,7 +25,7 @@ class Redact
     friend class DB::FieldVisitorToDebugString;
 
 protected:
-    Redact() {}
+    Redact() = default;
 
 private:
     // Log user data to log only when this flag is set to false.

dbms/src/Common/SharedLibrary.cpp

@@ -32,7 +32,7 @@ void * SharedLibrary::getImpl(const std::string & name, bool no_throw)
 {
     dlerror();
 
-    auto res = dlsym(handle, name.c_str());
+    auto * res = dlsym(handle, name.c_str());
 
     if (char * error = dlerror())
     {

dbms/src/Common/SimpleIncrement.h

@@ -11,7 +11,7 @@ struct SimpleIncrement
 {
     std::atomic<UInt64> value;
 
-    SimpleIncrement(UInt64 start = 0)
+    explicit SimpleIncrement(UInt64 start = 0)
         : value(start)
     {}