Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clang tidy for columns #3153

Closed
wants to merge 14 commits into from
Closed

fix clang tidy for columns #3153

wants to merge 14 commits into from

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Sep 26, 2021

What problem does this PR solve?

Issue Number:
close #2848
close #2849
close #2850
close #2854
close #2856
close #2859
close #2860
close #2845
close #2861
close #2863
close #2864
close #2865

Problem Summary:

What is changed and how it works?

Proposal: xxx

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 26, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • fuzhe1989

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 26, 2021
@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 26, 2021

waiting for #3152

dbms/src/Columns/ColumnDecimal.cpp Outdated Show resolved Hide resolved
dbms/src/Columns/ColumnNullable.cpp Outdated Show resolved Hide resolved
dbms/src/Columns/ColumnsCommon.cpp Outdated Show resolved Hide resolved
@fuzhe1989
Copy link
Contributor

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Oct 9, 2021

/run-all-tests

@SeaRise SeaRise requested a review from fuzhe1989 October 9, 2021 03:29
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 10, 2021
@fuzhe1989
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@fuzhe1989: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 399d306

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 10, 2021
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment