Push down ROUND(x)
on decimal types (#2492)
#2611
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #2492 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tics repo: git pr https://github.com/pingcap/tics/pull/2611
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #2426, part of #2550
Problem Summary: enable
ROUND(x)
on TiFlash.What is changed and how it works?
What's Changed:
IDataType.h
,DataTypesNumber.h
: addisFloatingPoint
.DAGExpressionAnalyzer.cpp
: constructtidbRound
fromtidbRoundWithFrac
.DAGUtils.cpp
: map TiPB codes to function names.FunctionsArithmetic.h
,toUnsigned.h
: move outtoUnsigned
for reusing inFunctionsRound.h
.FunctionsRound.cpp
: register new function.FunctionsRound.h
: the implementation.Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Release note
ROUND(X)
to TiFlash.