Fix function mod
decimal scale overflow (#2462)
#2608
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #2462 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tics repo: git pr https://github.com/pingcap/tics/pull/2608
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Problem Summary: #2402 (issue #2318) will overflow in decimal modulo.
What is changed and how it works?
What's Changed: This PR fixes the issue by assign modulo operation to
need_promote_type
inDecimalBinaryOperation
.Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note
MOD(N, M)
.