Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support add background tasks with specified interval #2571

Merged
merged 4 commits into from
Aug 5, 2021

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Aug 4, 2021

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: Support add background tasks with specified interval

What is changed and how it works?

Proposal: xxx

What's Changed: Currently every background task will run at a unified interval (about 10 seconds), but for some task we want to customize the run interval. For example, for gc task we want to run at interval about 10 minutes. Without this pr, we have to maintain a StopWatch for every task to make the task run at a specified interval which is tedious.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

Release note

  • No release note

@lidezhu
Copy link
Contributor Author

lidezhu commented Aug 4, 2021

/run-integration-tests

Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 5, 2021
@lidezhu
Copy link
Contributor Author

lidezhu commented Aug 5, 2021

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2021
@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@lidezhu merge failed.

@lidezhu
Copy link
Contributor Author

lidezhu commented Aug 5, 2021

/merge

@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 2577
  • 2579
  • 2440
  • 2579
  • 2573

@ti-srebot
Copy link
Collaborator

/run-all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants