Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uesless Analyzers #2549

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Conversation

fuzhe1989
Copy link
Contributor

The same as #2497, open a new pr cuz @leiysky has left PingCAP and his tics repo was automatically deleted.

What problem does this PR solve?

Problem Summary:
related to #2019
Analyzers are useless for us, I think it's ok to just remove them to make the codebase more clean.

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch:

Check List

Tests

  • No code

Side effects

Release note

  • No release note.

Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 3, 2021
@fuzhe1989
Copy link
Contributor Author

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2021
@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 2436

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit 4e5730c into pingcap:master Aug 3, 2021
@JaySon-Huang JaySon-Huang deleted the fuzhe/remove_analyzers branch August 3, 2021 10:14
@fuzhe1989 fuzhe1989 added the type/code-quality-improvement PR that can improve the code quality label Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/code-quality-improvement PR that can improve the code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants