Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Push down ADDDATE(), DATE_ADD() on String, Real types #2454

Merged
merged 3 commits into from
Aug 5, 2021
Merged

Push down ADDDATE(), DATE_ADD() on String, Real types #2454

merged 3 commits into from
Aug 5, 2021

Conversation

mengxin9014
Copy link
Contributor

@mengxin9014 mengxin9014 commented Jul 21, 2021 •
edited by zanmato1984
Loading

What problem does this PR solve?

Issue Number: close #2450

Problem Summary:

support ADDDATE() and DATE_ADD() pushed down to tiflash

What is changed and how it works?

support ADDDATE() and DATE_ADD() pushed down to tiflash

Check List

Tests

  • Integration test

Release note

  • support functions of ADDDATE() and DATE_ADD() pushed down to tiflash

@mengxin9014 mengxin9014 changed the title Push down ADDDATE(), DATE_ADD() on String, Real types WIP:Push down ADDDATE(), DATE_ADD() on String, Real types Jul 21, 2021
@mengxin9014 mengxin9014 changed the title WIP:Push down ADDDATE(), DATE_ADD() on String, Real types WIP: Push down ADDDATE(), DATE_ADD() on String, Real types Jul 21, 2021
@mengxin9014 mengxin9014 changed the title WIP: Push down ADDDATE(), DATE_ADD() on String, Real types Push down ADDDATE(), DATE_ADD() on String, Real types Jul 22, 2021
@mengxin9014 mengxin9014 linked an issue Jul 22, 2021 that may be closed by this pull request
Push down ADDDATE(), DATE_ADD() on String, Real types #2450
Closed
@mengxin9014 mengxin9014 changed the title Push down ADDDATE(), DATE_ADD() on String, Real types WIP: Push down ADDDATE(), DATE_ADD() on String, Real types Jul 22, 2021
@mengxin9014
Copy link
Contributor Author

/run-all-tests

@mengxin9014 mengxin9014 changed the title WIP: Push down ADDDATE(), DATE_ADD() on String, Real types Push down ADDDATE(), DATE_ADD() on String, Real types Jul 23, 2021
@zanmato1984 zanmato1984 added component/expression needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 type/enhancement The issue or PR belongs to an enhancement. labels Aug 4, 2021
zanmato1984
zanmato1984 approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 5, 2021
@zanmato1984
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 5, 2021
@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 2577
  • 2579
  • 2440
  • 2579
  • 2573
  • 2571

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit 36756d9 into pingcap:master Aug 5, 2021
@ti-srebot ti-srebot mentioned this pull request Aug 5, 2021
Closed
@ti-srebot
Copy link
Collaborator

cherry pick to release-5.0 in PR #2590

@ti-srebot ti-srebot mentioned this pull request Aug 5, 2021
Closed
@ti-srebot
Copy link
Collaborator

cherry pick to release-5.1 in PR #2591

JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Aug 5, 2021
@mengxin9014 @JaySon-Huang
Push down ADDDATE(), DATE_ADD() on String, Real types (pingcap#2454)
09d0aa0
@mengxin9014 mengxin9014 mentioned this pull request Aug 9, 2021
Closed
@mengxin9014 mengxin9014 linked an issue Aug 9, 2021 that may be closed by this pull request
Push down date related functions - ADDDATE, DATE, DATE_ADD #2425
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@LittleFall LittleFall Awaiting requested review from LittleFall

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 needs-cherry-pick-release-5.1 PR which needs to be cherry-picked to release-5.1 status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
3 participants
@mengxin9014 @zanmato1984 @ti-srebot