Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: push unix_timestamp, concat to TiFlash #2059

Merged
merged 15 commits into from
Jun 3, 2021

Conversation

LittleFall
Copy link
Contributor

@LittleFall LittleFall commented Jun 3, 2021

What problem does this PR solve?

Issue Number: close #1940, #1939

Problem Summary:

Function: push unix_timestamp, concat to TiFlash.

What is changed and how it works?

Proposal: xxx

What's Changed:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch: no need

Check List

Tests

  • Unit test
  • Integration test

Side effects

Release note

  • No release note.

LittleFall and others added 5 commits June 3, 2021 13:33
* squash

* fix bug

* fix bug.

* use old tidbConcat

* remove unrelated changes

* fix compile bug.

* refine tests

* fix test

* fix bug.

* update test

* fix
* fix build

* remove unstable test

* remove unstable test

* remove
@LittleFall LittleFall changed the title Cherrypick/unix timestamp,concat Function: push unix_timestamp, concat to TiFlash Jun 3, 2021
@LittleFall
Copy link
Contributor Author

/run-all-tests

@LittleFall LittleFall changed the title Function: push unix_timestamp, concat to TiFlash expression: push unix_timestamp, concat to TiFlash Jun 3, 2021
dbms/src/Common/MyTime.h Outdated Show resolved Hide resolved
@LittleFall
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 3, 2021
@LittleFall
Copy link
Contributor Author

/run-all-tests

@LittleFall LittleFall force-pushed the cherrypick/unix_timestamp,concat branch from 7fa528e to a84729b Compare June 3, 2021 08:45
@LittleFall
Copy link
Contributor Author

/run-all-tests

@LittleFall
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 2058
  • 2026
  • 2043
  • 2007

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 3, 2021
@LittleFall
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@leiysky leiysky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 3, 2021
@LittleFall
Copy link
Contributor Author

/run-all-tests

1 similar comment
@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot
Copy link
Collaborator

@LittleFall merge failed.

@LittleFall
Copy link
Contributor Author

ERROR: Queue task was cancelled

@LittleFall
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 2007
  • 2043
  • 2007
  • 2028
  • 2060
  • 2039
  • 2041

@LittleFall
Copy link
Contributor Author

/run-all-tests

@LittleFall
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 2028
  • 2060
  • 2039
  • 2041

@LittleFall
Copy link
Contributor Author

/run-all-tests

@LittleFall
Copy link
Contributor Author

image

@LittleFall
Copy link
Contributor Author

/run-all-tests

@LittleFall
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Collaborator

Your auto merge job has been accepted, waiting for:

  • 2060
  • 2039
  • 2041

@ti-srebot
Copy link
Collaborator

/run-all-tests

@ti-srebot ti-srebot merged commit 7e4d1bd into pingcap:master Jun 3, 2021
@LittleFall LittleFall deleted the cherrypick/unix_timestamp,concat branch June 4, 2021 01:36
@LittleFall
Copy link
Contributor Author

/label needs-cherry-pick-5.0

@ti-srebot ti-srebot added the needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 label Jun 4, 2021
@LittleFall
Copy link
Contributor Author

/run-cherry-picker

@ti-srebot
Copy link
Collaborator

cherry pick to release-5.0 in PR #2085

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.0 PR which needs to be cherry-picked to release-5.0 status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support concat function push down
5 participants