Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut down the wait time for syncSchema when failed in tiflash start #7671

Closed
hongyunyan opened this issue Jun 16, 2023 · 0 comments · Fixed by #7672
Closed

Cut down the wait time for syncSchema when failed in tiflash start #7671

hongyunyan opened this issue Jun 16, 2023 · 0 comments · Fixed by #7672
Labels
affects-6.1 affects-6.5 affects-7.1 type/enhancement The issue or PR belongs to an enhancement.

Comments

@hongyunyan
Copy link
Contributor

hongyunyan commented Jun 16, 2023 •
edited
Loading

Enhancement

When TiFlash restarts, if it syncs schema failed, we make a 60 times retry with each time sleep 3 seconds. While considering syncSchema will cost some time even failed, so 60 times retry may cost too many times, such as 23 min in some cases, which is inappropriate. Thus we need to change the wait logical, make it just wait for controllable time.
@hongyunyan hongyunyan added the type/enhancement The issue or PR belongs to an enhancement. label Jun 16, 2023
This was referenced Jun 16, 2023
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jun 16, 2023
@hongyunyan
Cut down the wait time for sync schema in restart (#7672)
cf98d94 
close #7671
This was referenced Jun 16, 2023
Closed
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jun 19, 2023
@hongyunyan
Cut down the wait time for sync schema in restart(release-6.5) (#7673)
599365e 
close #7671
@ti-chi-bot ti-chi-bot mentioned this issue Jun 27, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jun 27, 2023
@ti-chi-bot
Cut down the wait time for sync schema in restart (#7672) (#7705)
c7255f7 
close #7671
ti-chi-bot bot pushed a commit that referenced this issue Jun 28, 2023
@ti-chi-bot
Cut down the wait time for sync schema in restart (#7672) (#7675)
196d0b1 
close #7671
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.1 affects-6.5 affects-7.1 type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cut down the wait time for sync schema in restart hongyunyan/tiflash
3 participants
@JaySon-Huang @hongyunyan @ti-chi-bot