Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Regression Compared With release-6.5-20230107-v6.5.0 #6713

Closed
2 tasks done
Tracked by #6620
solotzg opened this issue Feb 2, 2023 · 1 comment
Closed
2 tasks done
Tracked by #6620

Performance Regression Compared With release-6.5-20230107-v6.5.0 #6713

solotzg opened this issue Feb 2, 2023 · 1 comment
Assignees
@xzhangxian1008
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@solotzg
Copy link
Contributor

solotzg commented Feb 2, 2023 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Benchmark

Env

  • TPCH-100
  • TiFlash x 3
  • TIFLASH REPLICA x 3
  • Base branch:
    • TiDB: e1a2b5865
    • TiFash: a69dfbc (master)
      • use exchange data compression FAST mode by default

TPCH Q9:

  • release-6.5-20230107-v6.5.0: 18.22s
  • master: 21.11s

TPCH Q5:

  • release-6.5-20230107-v6.5.0: 6.48s
  • master: 7.68s

Try To Fix

revert 7298855
revert 1870004
revert f9167f3

TPCH Q9: 19.90s

remove usage about

tiflash/dbms/src/DataStreams/HashJoinProbeBlockInputStream.h

Line 69 in 104f678

SquashingHashJoinBlockTransform squashing_transform;

632fdaa

TPCH Q9: 18.29s

Process
@solotzg solotzg added the type/bug The issue is confirmed as a bug. label Feb 2, 2023
@xzhangxian1008
Copy link
Contributor

/assign

@solotzg solotzg mentioned this issue Feb 2, 2023
Merged
12 tasks
@solotzg solotzg added type/enhancement The issue or PR belongs to an enhancement. and removed type/bug The issue is confirmed as a bug. labels Feb 2, 2023
ti-chi-bot pushed a commit that referenced this issue Feb 2, 2023
@solotzg
Remove usage about SquashingHashJoinBlockTransform in `HashJoinProb…
632fdaa 
…eBlockInputStream` (#6714)

ref #6713
This was referenced Feb 2, 2023
Closed
Merged
@solotzg solotzg closed this as completed Feb 10, 2023
@solotzg solotzg mentioned this issue Feb 10, 2023
Merged
12 tasks
ywqzzy pushed a commit to ywqzzy/tiflash_1 that referenced this issue Feb 13, 2023
@solotzg @ywqzzy
Remove usage about SquashingHashJoinBlockTransform in `HashJoinProb…
799dbde 
…eBlockInputStream` (pingcap#6714)

ref pingcap#6713

Signed-off-by: ywqzzy <592838129@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xzhangxian1008 xzhangxian1008

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@solotzg @xzhangxian1008