fix a panic issue in parallel agg when exception is thrown (#5433) (#…

…5437) close #5356
pingcap · Jul 21, 2022 · 76d5e3f · 76d5e3f
1 parent a3656a5
commit 76d5e3f
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/dbms/src/DataStreams/ParallelAggregatingBlockInputStream.cpp b/dbms/src/DataStreams/ParallelAggregatingBlockInputStream.cpp
@@ -182,10 +182,9 @@ void ParallelAggregatingBlockInputStream::Handler::onFinish()
 void ParallelAggregatingBlockInputStream::Handler::onException(std::exception_ptr & exception, size_t thread_num)
 {
     parent.exceptions[thread_num] = exception;
-    /// can not cancel parent inputStream or the exception might be lost
     if (!parent.executed)
         /// kill the processor so ExchangeReceiver will be closed
-        parent.processor.cancel(true);
+        parent.cancel(true);
 }