Skip to content

Commit

Permalink
refine comment
Browse files Browse the repository at this point in the history
  • Loading branch information
ywqzzy committed Jan 3, 2023
1 parent 364375e commit 59fd171
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion dbms/src/Debug/MockStorage.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ BlockInputStreamPtr MockStorage::getStreamFromDeltaMerge(Context & context, Int6
SelectQueryInfo query_info;
query_info.query = std::make_shared<ASTSelectQuery>();
query_info.mvcc_query_info = std::make_unique<MvccQueryInfo>(context.getSettingsRef().resolve_locks, std::numeric_limits<UInt64>::max(), scan_context);
BlockInputStreams ins = storage->read(column_names, query_info, context, stage, 8192, 1); // Todo: Should we change the params?
BlockInputStreams ins = storage->read(column_names, query_info, context, stage, 8192, 1); // TODO: Support config max_block_size and num_streams

BlockInputStreamPtr in = ins[0];
return in;
Expand Down
2 changes: 1 addition & 1 deletion dbms/src/TestUtils/ExecutorTestUtils.h
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ using ColMyDateNullableType = std::optional<typename TypeTraits<MyDate>::FieldTy
using ColMyDateTimeNullableType = std::optional<typename TypeTraits<MyDateTime>::FieldType>;
using ColDecimalNullableType = std::optional<typename TypeTraits<Decimal32>::FieldType>;

// non nullable tyoe
// non nullable type
using ColUInt64Type = typename TypeTraits<UInt64>::FieldType;
using ColInt64Type = typename TypeTraits<Int64>::FieldType;
using ColFloat64Type = typename TypeTraits<Float64>::FieldType;
Expand Down

0 comments on commit 59fd171

Please sign in to comment.