Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: enable hash partition and range columns partition by default #9936

Merged
merged 5 commits into from
May 8, 2019

Conversation

tiancaiamao
Copy link
Contributor

What problem does this PR solve?

Enable a feature

What is changed and how it works?

Check List

Tests

  • No code

@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #9936 into master will increase coverage by 0.0017%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master      #9936        +/-   ##
================================================
+ Coverage   77.3752%   77.3769%   +0.0017%     
================================================
  Files           412        412                
  Lines         85698      85665        -33     
================================================
- Hits          66309      66285        -24     
+ Misses        14353      14350         -3     
+ Partials       5036       5030         -6

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp requested a review from lysu May 5, 2019 12:55
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DNM

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@tiancaiamao
Copy link
Contributor Author

Now that #10273 has been merged, I'll remove the DNM tag

PTAL @jackysp @lysu

@tiancaiamao tiancaiamao added the status/LGT2 Indicates that a PR has LGTM 2. label May 8, 2019
@tiancaiamao
Copy link
Contributor Author

/run-idc-jenkins-ci-tidb/common-test

@tiancaiamao tiancaiamao requested a review from lysu May 8, 2019 07:08
@tiancaiamao tiancaiamao merged commit e56a14b into pingcap:master May 8, 2019
@tiancaiamao tiancaiamao deleted the enable-hash-partition branch May 8, 2019 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants