Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan: support subquery in Do statement (#8343) #9879

Merged
merged 4 commits into from
Mar 27, 2019
Merged

plan: support subquery in Do statement (#8343) #9879

merged 4 commits into from
Mar 27, 2019

Conversation

eurekaka
Copy link
Contributor

cherry-pick #8343

@eurekaka eurekaka added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner type/2.0 cherry-pick labels Mar 25, 2019
@zz-jason
Copy link
Member

@eurekaka Please fix the build

@zz-jason
Copy link
Member

LGTM

@zz-jason
Copy link
Member

/run-all-tests tidb-test=release-2.0 tikv=release-2.1 pd=release-2.0

@eurekaka
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 tikv=release-2.1 pd=release-2.0

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 25, 2019
@eurekaka
Copy link
Contributor Author

/run-unit-test
/run-integration-compatibility-test
/run-integration-common-test

@zhouqiang-cl
Copy link
Contributor

/run-integration-common-test tidb-test=release-2.0 tikv=release-2.1 pd=release-2.0

2 similar comments
@eurekaka
Copy link
Contributor Author

/run-integration-common-test tidb-test=release-2.0 tikv=release-2.1 pd=release-2.0

@eurekaka
Copy link
Contributor Author

/run-integration-common-test tidb-test=release-2.0 tikv=release-2.1 pd=release-2.0

@eurekaka
Copy link
Contributor Author

/run-integration-common-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

1 similar comment
@eurekaka
Copy link
Contributor Author

/run-integration-common-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

alivxxx
alivxxx approved these changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 27, 2019
@zz-jason zz-jason merged commit 4f6eef9 into pingcap:release-2.0 Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eurekaka @zz-jason @zhouqiang-cl @alivxxx