Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix str_to_date func compatible issues 9773 #9819

Merged
merged 5 commits into from
Mar 21, 2019

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Mar 20, 2019

What problem does this PR solve?

Fix the problem that str_to_date is not compatible with MySQL

fix #9773

What is changed and how it works?

keep format '%H' without '%p'

Check List

Tests

  • Unit test
  • Integration test

@CLAassistant
Copy link

CLAassistant commented Mar 20, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #9819 into master will increase coverage by 0.0074%.
The diff coverage is 33.3333%.

@@               Coverage Diff                @@
##             master      #9819        +/-   ##
================================================
+ Coverage   67.1505%   67.1579%   +0.0074%     
================================================
  Files           381        381                
  Lines         80053      80056         +3     
================================================
+ Hits          53756      53764         +8     
+ Misses        21502      21500         -2     
+ Partials       4795       4792         -3

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Please add some tests to cover the bug fix.

@zz-jason zz-jason added contribution This PR is from a community contributor. type/bugfix This PR fixes a bug. component/expression labels Mar 20, 2019
@b41sh
Copy link
Member Author

b41sh commented Mar 20, 2019

@zz-jason Already added

@xiekeyi98
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@xiekeyi98 xiekeyi98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for your contribution.

@xiekeyi98 xiekeyi98 added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed labels Mar 20, 2019
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 21, 2019
@ngaut ngaut merged commit b4cc3e4 into pingcap:master Mar 21, 2019
@zz-jason
Copy link
Member

@b41sh Could you help us to cherry pick this change to release 2.1?

b41sh added a commit to b41sh/tidb that referenced this pull request Mar 31, 2019
@b41sh
Copy link
Member Author

b41sh commented Mar 31, 2019

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

str_to_date is not compatible with MySQL
6 participants