Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix last_day function #9746

Merged
merged 3 commits into from
Mar 15, 2019
Merged

expression: fix last_day function #9746

merged 3 commits into from
Mar 15, 2019

Conversation

wjhuang2016
Copy link
Member

What problem does this PR solve?

For #9731

What is changed and how it works?

Retun NULL as long as the month is 0.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

@xiekeyi98 xiekeyi98 added contribution This PR is from a community contributor. component/expression labels Mar 15, 2019
@codecov
Copy link

codecov bot commented Mar 15, 2019 •
edited
Loading

Codecov Report

Merging #9746 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##            master      #9746        +/-   ##
===============================================
- Coverage   67.234%   67.2239%   -0.0101%     
===============================================
  Files          380        380                
  Lines        79787      79787                
===============================================
- Hits         53644      53636         -8     
- Misses       21357      21365         +8     
  Partials      4786       4786

@lysu
Copy link
Contributor

lysu commented Mar 15, 2019

/run-all-tests

lysu
lysu reviewed Mar 15, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu requested a review from qw4990 March 15, 2019 06:20
@lysu lysu added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed labels Mar 15, 2019
qw4990
qw4990 approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2019
@qw4990
Copy link
Contributor

qw4990 commented Mar 15, 2019

@wjhuang2016 thanks for your contribution.
Could you please cherry-pick this PR into branch release 2.1 after it's merged.

@wjhuang2016
Copy link
Member Author

@wjhuang2016 thanks for your contribution.
Could you please cherry-pick this PR into branch release 2.1 after it's merged.

Please tell me how to do it, I'm not familiar with git.

@qw4990
Copy link
Contributor

qw4990 commented Mar 15, 2019 •
edited
Loading

@wjhuang2016 thanks for your contribution.
Could you please cherry-pick this PR into branch release 2.1 after it's merged.

Please tell me how to do it, I'm not familiar with git.

Fetch branch release-2.1 to your local and then cherry-pick this PR into branch release-2.1 locally, then submit a new PR into TiDB release-2.1 😺

@qw4990 qw4990 merged commit 9187e3d into pingcap:master Mar 15, 2019
@qw4990 qw4990 mentioned this pull request Mar 18, 2019
Closed
30 tasks
@wjhuang2016 wjhuang2016 deleted the fix_last_day branch November 17, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wjhuang2016 @lysu @qw4990 @xiekeyi98