Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add rollback for load data statement #9444

Merged
merged 6 commits into from
Feb 28, 2019
Merged

*: add rollback for load data statement #9444

merged 6 commits into from
Feb 28, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

Add transaction rollback for load data.

What is changed and how it works?

Check List

Tests

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

@crazycs520 crazycs520 added the sig/transaction SIG:Transaction label Feb 25, 2019
@codecov-io
Copy link

codecov-io commented Feb 25, 2019 •
edited
Loading

Codecov Report

Merging #9444 into master will increase coverage by <.01%.
The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9444      +/-   ##
==========================================
+ Coverage   67.38%   67.39%   +<.01%     
==========================================
  Files         374      374              
  Lines       78653    78659       +6     
==========================================
+ Hits        53000    53009       +9     
+ Misses      20894    20891       -3     
  Partials     4759     4759
Impacted Files Coverage Δ
server/conn.go 59.09% <46.15%> (+0.19%) ⬆️
ddl/session_pool.go 82.75% <0%> (-10.35%) ⬇️
executor/distsql.go 71.78% <0%> (-0.46%) ⬇️
executor/executor.go 68.44% <0%> (+0.27%) ⬆️
expression/schema.go 94.53% <0%> (+0.78%) ⬆️
ddl/delete_range.go 76.19% <0%> (+1.05%) ⬆️
store/tikv/scan.go 77.31% <0%> (+3.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c97db8...beacc55. Read the comment docs.

@crazycs520
Copy link
Contributor Author

@tiancaiamao @jackysp @lysu PTAL

@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-all-tests

@zz-jason zz-jason requested a review from tiancaiamao February 25, 2019 11:48
zz-jason
zz-jason reviewed Feb 25, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 25, 2019
@crazycs520
Copy link
Contributor Author

@tiancaiamao @jackysp PTAL

zimulala
zimulala reviewed Feb 26, 2019
View reviewed changes
server/conn.go Outdated Show resolved Hide resolved
@tiancaiamao
Copy link
Contributor

Please address comment, rest looks good to me

@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-unit-test

jackysp
jackysp reviewed Feb 28, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp requested a review from zimulala February 28, 2019 06:36
@crazycs520
Copy link
Contributor Author

@tiancaiamao PTAL

@crazycs520 crazycs520 added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 28, 2019
@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520 crazycs520 merged commit 2c90855 into pingcap:master Feb 28, 2019
@crazycs520 crazycs520 deleted the load-data-rollback branch February 28, 2019 13:03
@jackysp jackysp mentioned this pull request Jun 19, 2019
Closed
jackysp pushed a commit to jackysp/tidb that referenced this pull request Jun 19, 2019
@crazycs520 @jackysp
*: add rollback for load data statement (pingcap#9444)
149f6a5 
Conflicts:
	server/conn.go
jackysp added a commit that referenced this pull request Jun 24, 2019
@jackysp
*: add rollback for load data statement (#9444) (#10862)
42eced8
@jackysp jackysp mentioned this pull request Jul 3, 2019
Merged
@lysu lysu mentioned this pull request Sep 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@jackysp jackysp jackysp left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@zimulala zimulala Awaiting requested review from zimulala

Assignees
No one assigned
Labels
sig/transaction SIG:Transaction status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@crazycs520 @codecov-io @tiancaiamao @zimulala @jackysp @zz-jason