Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: make TiDB treat charset and collate case insensitive #8577 #9338

Merged
merged 1 commit into from
Feb 18, 2019
Merged

ddl: make TiDB treat charset and collate case insensitive #8577 #9338

merged 1 commit into from
Feb 18, 2019

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Feb 18, 2019

What problem does this PR solve?

Port from #8577

@winkyao winkyao changed the title ddl: update parser to make TiDB treat charset and collate case insensitive #8577 ddl: make TiDB treat charset and collate case insensitive #8577 Feb 18, 2019
@jackysp
Copy link
Member

jackysp commented Feb 18, 2019

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added status/all tests passed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 18, 2019
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520 crazycs520 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 18, 2019
@winkyao winkyao merged commit f9df5fa into pingcap:release-2.0 Feb 18, 2019
@winkyao winkyao deleted the case_insensive_collate branch February 18, 2019 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants