*: support "show create user" #9240

lnhote · 2019-02-01T12:38:43Z

What problem does this PR solve?

Support SHOW CREATE USER as in MySQL 5.7.
fix #7733

What is changed and how it works?

add GetEncodedPassword function to Manager interface.
add support for ShowCreateTable in buildShowSchema function.
add support for ShowCreateUser in ShowExec.fetchAll function

Check List

Tests

Unit test

Code changes

exported function/method change
Has exported variable/fields change
Has interface methods change

# Conflicts: # go.mod # go.sum

# Conflicts: # go.mod # go.sum # planner/core/planbuilder.go

shenli · 2019-02-05T14:29:19Z

@lnhote Thanks!
Please fix the CI.

morgo · 2019-02-08T17:00:52Z

@lnhote Thank you for working on this! It looks like it just needs go fmt to be run:

go fmt privilege/privileges/privileges.go

lnhote · 2019-02-10T04:19:37Z

Thanks for the help. Please take another look.

codecov-io · 2019-02-10T04:20:38Z

Codecov Report

Merging #9240 into master will increase coverage by 0.13%.
The diff coverage is 51.21%.

@@            Coverage Diff             @@
##           master    #9240      +/-   ##
==========================================
+ Coverage   67.02%   67.15%   +0.13%     
==========================================
  Files         373      373              
  Lines       78150    78191      +41     
==========================================
+ Hits        52378    52512     +134     
+ Misses      21094    20977     -117     
- Partials     4678     4702      +24

Impacted Files	Coverage Δ
util/testkit/testkit.go	`14.16% <0%> (-1.02%)`	⬇️
planner/core/planbuilder.go	`49.35% <33.33%> (-0.04%)`	⬇️
privilege/privileges/privileges.go	`57.31% <45.45%> (-1.84%)`	⬇️
executor/show.go	`45.1% <78.94%> (+1.22%)`	⬆️
ddl/delete_range.go	`75.13% <0%> (-2.65%)`	⬇️
infoschema/infoschema.go	`76.31% <0%> (-1.32%)`	⬇️
store/tikv/lock_resolver.go	`41.7% <0%> (-0.95%)`	⬇️
executor/distsql.go	`72.24% <0%> (+0.45%)`	⬆️
executor/join.go	`79.42% <0%> (+0.52%)`	⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a24081...81b503e. Read the comment docs.

morgo · 2019-02-10T09:37:05Z

@lnhote can you please add tests for:

a user that doesn't exist
the user exists but the host portion doesn't match

I am getting the following behavior on a fresh install. Both are different results from MySQL:

mysql> SET PASSWORD='abcd';
2019/02/10 02:35:19.953 session.go:1639: [info] [CRUCIAL OPERATION] con:1 schema_ver:15 set password for user <nil> (by root@127.0.0.1).
Query OK, 0 rows affected (0.00 sec)

mysql> SHOW CREATE USER 'root'@'%'; <-- correct
+-------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| CREATE USER for root@%                                                                                                                                            |
+-------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| CREATE USER 'root'@'%' IDENTIFIED WITH 'mysql_native_password' AS '*A154C52565E9E7F94BFC08A1FE702624ED8EFFDA' REQUIRE NONE PASSWORD EXPIRE DEFAULT ACCOUNT UNLOCK |
+-------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)

mysql> SHOW CREATE USER 'root'@'nowhere'; <--- incorrect
+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| CREATE USER for root@nowhere                                                                                                                                            |
+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| CREATE USER 'root'@'nowhere' IDENTIFIED WITH 'mysql_native_password' AS '*A154C52565E9E7F94BFC08A1FE702624ED8EFFDA' REQUIRE NONE PASSWORD EXPIRE DEFAULT ACCOUNT UNLOCK |
+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)

mysql> show create user 'aaa'@'aaa'; <-- incorrect
2019/02/10 02:35:39.737 privileges.go:65: [error] Get user privilege record fail: user aaa, host aaa
+---------------------------------------------------------------------------------------------------------------------------+
| CREATE USER for aaa@aaa                                                                                                   |
+---------------------------------------------------------------------------------------------------------------------------+
| CREATE USER 'aaa'@'aaa' IDENTIFIED WITH 'mysql_native_password' AS '' REQUIRE NONE PASSWORD EXPIRE DEFAULT ACCOUNT UNLOCK |
+---------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)

morgo · 2019-02-10T09:39:21Z

Expected behavior:

mysql [localhost:5724] {msandbox} ((none)) > show grants for 'root'@'nowhere';
ERROR 1141 (42000): There is no such grant defined for user 'root' on host 'nowhere'
mysql [localhost:5724] {msandbox} ((none)) > show grants for 'aaa'@'aaa';
ERROR 1141 (42000): There is no such grant defined for user 'aaa' on host 'aaa'

executor/builder.go

# Conflicts: # privilege/privileges/privileges.go

executor/show.go

morgo · 2019-02-15T14:44:23Z

@lnhote I left two review comments. It looks good otherwise. Thanks!

morgo · 2019-02-15T18:09:29Z

LGTM

morgo · 2019-02-19T18:18:02Z

@lnhote please resolve conflicts.

lnhote · 2019-02-20T03:25:32Z

@morgo PTAL.

morgo · 2019-02-20T04:31:45Z

LGTM
@jackysp PTAL

jackysp · 2019-02-20T09:33:54Z

executor/show_test.go

@@ -16,13 +16,13 @@ package executor_test
 import (
 	"context"
 	"fmt"
-


Please do not remove this line, keep the sys libs separate with the 3rd party libs.

Adding the blank line will cause check_dev to fail.

Why check_dev could pass in master branch? I think you've added a blank line with some white spaces, try to keep it as it used to be.

I fixed it.

jackysp · 2019-02-21T04:27:27Z

/run-all-tests

jackysp · 2019-02-21T05:07:47Z

/run-integration-common-test

jackysp · 2019-02-21T05:08:03Z

/run-integration-ddl-test

jackysp

LGTM

lnhote and others added 9 commits January 7, 2019 23:31

parser: add SHOW CREATE USER syntax

293d2da

update version

ed919b5

Merge branch 'master' into parser_add_show_create_user_syntax

b003a69

Merge branch 'master' into parser_add_show_create_user_syntax

a33047a

Update TiDB to use the latest parser

b1a3bd8

Merge branch 'master' of https://github.com/pingcap/tidb

291edcc

# Conflicts: # go.mod # go.sum

support show create user.

86d4044

add ut

5722fe5

Merge branch 'master' into support_show_create_user

bdf52f4

# Conflicts: # go.mod # go.sum # planner/core/planbuilder.go

shenli added the contribution This PR is from a community contributor. label Feb 5, 2019

lnhote added 2 commits February 10, 2019 12:05

Merge branch 'master' into support_show_create_user

83b6f06

fmt

6c7536c

morgo reviewed Feb 14, 2019

View reviewed changes

executor/builder.go Outdated Show resolved Hide resolved

zz-jason changed the title ~~Support show create user~~ *: support "show create user" Feb 15, 2019

zz-jason added the type/new-feature label Feb 15, 2019

lnhote added 2 commits February 15, 2019 17:14

add more tests.

c2cc0e9

Merge branch 'master' into support_show_create_user

40c166d

# Conflicts: # privilege/privileges/privileges.go

morgo reviewed Feb 15, 2019

View reviewed changes

executor/show.go Show resolved Hide resolved

this is not necessary for "show create user"

71a4286

morgo added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 15, 2019

Merge branch 'master' into support_show_create_user

363f641

jackysp reviewed Feb 20, 2019

View reviewed changes

lnhote added 3 commits February 20, 2019 18:03

add line.

8e84f3e

remove space

43facb7

Merge branch 'master' into support_show_create_user

6661cc8

jackysp added the status/all tests passed label Feb 21, 2019

Merge branch 'master' into support_show_create_user

81b503e

jackysp approved these changes Feb 21, 2019

View reviewed changes

jackysp merged commit aabd330 into pingcap:master Feb 21, 2019

morgo mentioned this pull request Feb 26, 2019

SHOW CREATE USER syntax creates non-creatable users #9462

Closed

aytrack mentioned this pull request Oct 31, 2019

toc, reference: delete show create user usage from v2.1 pingcap/docs-cn#2000

Merged

lilin90 mentioned this pull request Nov 12, 2019

v2.1/*: delete "show create user" pingcap/docs#1646

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

*: support "show create user" #9240

*: support "show create user" #9240

lnhote commented Feb 1, 2019 •

edited by zz-jason

Loading

shenli commented Feb 5, 2019

morgo commented Feb 8, 2019

lnhote commented Feb 10, 2019

codecov-io commented Feb 10, 2019 •

edited

Loading

morgo commented Feb 10, 2019

morgo commented Feb 10, 2019

morgo commented Feb 15, 2019

morgo commented Feb 15, 2019

morgo commented Feb 19, 2019

lnhote commented Feb 20, 2019

morgo commented Feb 20, 2019

jackysp Feb 20, 2019

lnhote Feb 20, 2019

jackysp Feb 21, 2019

lnhote Feb 21, 2019

jackysp commented Feb 21, 2019

jackysp commented Feb 21, 2019

jackysp commented Feb 21, 2019

jackysp left a comment

*: support "show create user" #9240

*: support "show create user" #9240

Conversation

lnhote commented Feb 1, 2019 • edited by zz-jason Loading

What problem does this PR solve?

What is changed and how it works?

Check List

shenli commented Feb 5, 2019

morgo commented Feb 8, 2019

lnhote commented Feb 10, 2019

codecov-io commented Feb 10, 2019 • edited Loading

Codecov Report

morgo commented Feb 10, 2019

morgo commented Feb 10, 2019

morgo commented Feb 15, 2019

morgo commented Feb 15, 2019

morgo commented Feb 19, 2019

lnhote commented Feb 20, 2019

morgo commented Feb 20, 2019

jackysp Feb 20, 2019

Choose a reason for hiding this comment

lnhote Feb 20, 2019

Choose a reason for hiding this comment

jackysp Feb 21, 2019

Choose a reason for hiding this comment

lnhote Feb 21, 2019

Choose a reason for hiding this comment

jackysp commented Feb 21, 2019

jackysp commented Feb 21, 2019

jackysp commented Feb 21, 2019

jackysp left a comment

Choose a reason for hiding this comment

lnhote commented Feb 1, 2019 •

edited by zz-jason

Loading

codecov-io commented Feb 10, 2019 •

edited

Loading