Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: return error if autoid overflows shard bits. (#8936) #8978

Merged
merged 6 commits into from
Jan 10, 2019
Merged

executor: return error if autoid overflows shard bits. (#8936) #8978

merged 6 commits into from
Jan 10, 2019

Conversation

winkyao
Copy link
Contributor

@winkyao winkyao commented Jan 8, 2019

What problem does this PR solve?

cherry-pick from #8936

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 8, 2019
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

zz-jason commented Jan 9, 2019

@winkyao Please fix CI:

Makefile:86: recipe for target 'errcheck' failed

@winkyao
Copy link
Contributor Author

winkyao commented Jan 10, 2019

/run-all-tests tikv=release-2.0 tidb-test=release-2.0 pd=release-2.0

@jackysp jackysp added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 10, 2019
@zz-jason
Copy link
Member

/run-unit-test tikv=release-2.0 tidb-test=release-2.0 pd=release-2.0 gofail=etcd-io

@zz-jason zz-jason merged commit ca75950 into pingcap:release-2.0 Jan 10, 2019
@winkyao winkyao deleted the cherry-pick-2.0 branch January 10, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants