*: unify all integer types to int64 and uint64 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify type related codes.
| } else { | ||
| casted = uint32(val) | ||
| casted = uint64(val) | ||
| } | ||
| } else { | ||
| if val > 1<<23-1 || errCode == errCodeOverflowUpper { |
There was a problem hiding this comment.
we may define a const for MinInt24/MaxInt24/MaxUint24
address comments
|
LGTM |
1 similar comment
|
LGTM |
coocood
added a commit
that referenced
this pull request
Sep 10, 2015
*: unify all integer types to int64 and uint64
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
* vendor: truly turn on Go 1.11 modules Since the dependencies like TiDB are now compatible with modules, we could now switch on GO111MODULE and remove the $GOPATH requirement. * tests: fix spurious test failure caused by non-deterministic start order
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
okJiang
pushed a commit
to okJiang/tidb
that referenced
this pull request
Oct 19, 2021
* move special named file to bash * Revert "move special named file to bash" This reverts commit 2bf11a984c7362763e21a9536c45d27af1d1bcf9. * refine code * fix bug * change mv to cp
hawkingrei
pushed a commit
to hawkingrei/tidb
that referenced
this pull request
May 31, 2022
iosmanthus
pushed a commit
to iosmanthus/tidb
that referenced
this pull request
Oct 31, 2022
Signed-off-by: disksing <i@disksing.com> Signed-off-by: disksing <i@disksing.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify type related code.