Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Support show current background job info #889

Merged
merged 3 commits into from
Feb 19, 2016
Merged

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Feb 3, 2016

#800

Handle to the last TODO.

@@ -44,42 +47,70 @@ func (d *ddl) GetScope(status string) variable.ScopeFlag {
return variable.DefaultScopeFlag
}

// Stat returns the DDL statistics.
func (d *ddl) Stats() (map[string]interface{}, error) {
func replacePrefix(str, old, new string) string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems needless to extract a function, it is not too long.

@qiuyesuifeng
Copy link
Member

LGTM

@zimulala
Copy link
Contributor Author

PTAL @coocood @shenli

@coocood
Copy link
Member

coocood commented Feb 17, 2016

LGTM

zimulala added a commit that referenced this pull request Feb 19, 2016
*: Support show current background job info
@zimulala zimulala merged commit 871679b into master Feb 19, 2016
@zimulala zimulala deleted the zimuxia/bg-job-stats branch February 19, 2016 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants