-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: modify different character sets varchar type column maximum length limit #8818
Conversation
069c6ad
to
8e5b244
Compare
@winkyao @zimulala @crazycs520 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix tests.
6ef0ca7
to
25f9ee4
Compare
@winkyao @zimulala @crazycs520 PTAL |
@zimulala @crazycs520 PTAL |
Codecov Report
@@ Coverage Diff @@
## master #8818 +/- ##
==========================================
- Coverage 67.27% 67.26% -0.01%
==========================================
Files 371 371
Lines 75972 75997 +25
==========================================
+ Hits 51108 51123 +15
- Misses 20354 20362 +8
- Partials 4510 4512 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
/run-all-tests |
What problem does this PR solve?
We execute the following sql , found that tidb and mysql behave differently.
What is changed and how it works?
Different character sets varchar type column maximum length limit is not the same.
There are default settings for character sets and collations at four levels: server, database, table, and column.
Check List
Tests
This change is