executor: refine HashAgg.Close when unparallelExec #8810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-unit-tests |
|
/run-all-tests |
eurekaka
added
status/LGT1
zz-jason
added
status/LGT2
|
@XuHuaiyu Could you add a gofail test? |
|
Please add a test case. |
winoros
reviewed
Dec 26, 2018
|
/run-unit-test |
1 similar comment
|
/run-unit-test |
|
PTAL @zz-jason gofail test added |
zz-jason
reviewed
Dec 27, 2018
| tk.MustExec(`drop table if exists t;`) | ||
| tk.MustExec("create table t(a int, b int)") | ||
| tk.MustExec("insert into t values(1,1),(2,2)") | ||
| result := tk.MustQuery("desc select sum(a) from (select cast(t.a as signed) as a, b from t) t group by b;") |
There was a problem hiding this comment.
A simple case to use hash aggregate is
select sum(a) from t group by b;There was a problem hiding this comment.
Do we really need this test case? If the planner hasn't chosen the Hash Aggregate operator, the following gofail test would not passed I think.
There was a problem hiding this comment.
- The case can also check whether the child of HashAgg is closed correctly, so I make a Projection there.
- Yep, the explain result is not really needed, I'll make it as a comment.
zz-jason
reviewed
Dec 27, 2018
| rs := rss[0] | ||
| chk := rs.NewChunk() | ||
| err = rs.Next(ctx, chk) | ||
| c.Assert(err, NotNil) |
There was a problem hiding this comment.
It's better to check the error message
AndrewDi
pushed a commit
to AndrewDi/tidb
that referenced
this pull request
Dec 28, 2018
yu34po
pushed a commit
to yu34po/tidb
that referenced
this pull request
Jan 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #8787
What is changed and how it works?
Close the child executor when HashAgg executes unparalleled.
Check List
Tests
exists leak tests
Code changes
Side effects
N/A
Related changes
release-2.1
This change is