executor: fix overflow error message of update
#8457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
|
|
|
@exialin Thanks for your contribution. |
|
/run-all-tests |
|
@XuHuaiyu PTAL |
zz-jason
approved these changes
Nov 26, 2018
XuHuaiyu
added
type/compatibility
contribution
zz-jason
added
status/LGT2
|
/run-all-tests |
|
@exialin could you please cherry-pick this commit to the release-2.1 and release-2.0 branch? |
|
@zz-jason Sure. But release-2.0 does not have |
|
@exialin OK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #8119 to make TiDB consistent with MySQL when updated value overflows.
However, the row number showed by the error message is trivial, as discussed in that issue.
What is changed and how it works?
Check error type in
handleErr.Check List
Tests
This change is