domain,session: simplify the session pool of domain #8456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The session pool now just serve as a cache, close the pool will no longer wait for all resources to be put back to the pool. Fix the bug that TiDB may hang a long time even after it get the exit signal
zz-jason
added
type/enhancement
tiancaiamao
added
the
priority/release-blocker
zz-jason
reviewed
Nov 27, 2018
| } | ||
| } | ||
|
|
||
| func (p *sessionPool) Get() (resource pools.Resource, err error) { |
There was a problem hiding this comment.
Not necessary.
line 629 handles the sessionPool is closed scene.
lysu
reviewed
Nov 27, 2018
|
LGTM |
zz-jason
approved these changes
Nov 27, 2018
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 1 of 1 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lysu)
lysu
approved these changes
Nov 27, 2018
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, 1 of 1 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lysu)
zz-jason
approved these changes
Nov 27, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4.
Reviewable status:complete! all files reviewed, all discussions resolved
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Nov 27, 2018
This was referenced Nov 27, 2018
ngaut
pushed a commit
that referenced
this pull request
Nov 27, 2018
tiancaiamao
added a commit
to tiancaiamao/tidb
that referenced
this pull request
Nov 29, 2018
zz-jason
pushed a commit
that referenced
this pull request
Nov 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix the bug that TiDB may hang a long time even after it get the exit signal.
DDL or stats may take sessions from the session pool to
ExecRestrictedSQLfor a long time,while the old pool will block waiting until the session to put back to the pool.
What is changed and how it works?
The session pool now just serve as a cache, close the pool will no longer
wait for all resources to be put back to the pool.
Check List
Tests
PTAL @winkyao @zimulala
This change is