Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: add check when add foreign key. (#8050) #8421

Merged
merged 4 commits into from
Nov 24, 2018

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Nov 23, 2018

What problem does this PR solve?

merge #8410 first.
cherry-pick #8050


This change is Reviewable

@crazycs520 crazycs520 changed the title Check add foreign 2.0 ddl: check foreign key when add foreign key. Nov 23, 2018
@zz-jason zz-jason changed the title ddl: check foreign key when add foreign key. ddl: add check when add foreign key. (#8050) Nov 23, 2018
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fix conflicts

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. component/DDL-need-LGT3 labels Nov 24, 2018
@crazycs520
Copy link
Contributor Author

/run-sqllogic-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

2 similar comments
@crazycs520
Copy link
Contributor Author

/run-sqllogic-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@crazycs520
Copy link
Contributor Author

/run-sqllogic-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@iamxy
Copy link
Member

iamxy commented Nov 24, 2018

/run-sqllogic-test tidb-test=release-2.0

@zz-jason zz-jason merged commit 420d8da into pingcap:release-2.0 Nov 24, 2018
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants