Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: add check when create table with foreign key. (#7885) #8407

Merged
merged 4 commits into from
Nov 23, 2018

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Nov 22, 2018

What problem does this PR solve?

cherry-pick from #7885

What is changed and how it works?


This change is Reviewable

@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1

* ddl: add check when create table with foreign key
@crazycs520
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 pd=release-2.1 tikv=release-2.1

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

LGTM

zz-jason
zz-jason previously approved these changes Nov 23, 2018
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed labels Nov 23, 2018
@crazycs520 crazycs520 changed the title ddl: check foreign key ddl: check foreign key when create table. Nov 23, 2018
@zz-jason zz-jason changed the title ddl: check foreign key when create table. ddl: add check when create table with foreign key. (#7885) Nov 23, 2018
@zz-jason zz-jason merged commit 830c013 into pingcap:release-2.1 Nov 23, 2018
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants