Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update pkg/errors && add pump client in vendor #8093

Merged
merged 3 commits into from
Oct 29, 2018
Merged

update pkg/errors && add pump client in vendor #8093

merged 3 commits into from
Oct 29, 2018

Conversation

WangXiangUSTC
Copy link
Contributor

What problem does this PR solve?

add some function to adjust juju/errors in pkg/errors, so update this pkg
add pump client in vendor, I will use pump client to send binlog next pr.
same with pr #8051

What is changed and how it works?

dep ensure -update github.com/pkg/errors
dep ensure -add github.com/pingcap/tidb-tools/tidb-binlog/pump_client@5db58e3b7e6613456551c40d011806a346b2f44a
sh hack/clean_vendor.sh

@WangXiangUSTC WangXiangUSTC requested review from lysu and jackysp October 29, 2018 09:40
@zz-jason
Copy link
Member

/run-all-tests

@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 29, 2018
@zz-jason
Copy link
Member

@lamxTyler @winoros PTAL

alivxxx
alivxxx approved these changes Oct 29, 2018
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 29, 2018
@jackysp jackysp merged commit ebebc2a into pingcap:release-2.1 Oct 29, 2018
@WangXiangUSTC WangXiangUSTC deleted the update_vendor branch November 11, 2018 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx approved these changes

@lysu lysu Awaiting requested review from lysu

@jackysp jackysp Awaiting requested review from jackysp

Assignees
No one assigned
Labels
component/binlog status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WangXiangUSTC @zz-jason @alivxxx @jackysp