*: enable range typed table partition #8011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
12 tasks
tiancaiamao
added
the
type/enhancement
|
/run-integration-tests |
tiancaiamao
added
status/LGT1
jackysp
reviewed
Oct 23, 2018
|
After a partitioned table is created, turn off the flag is to late: So this feature is controlled by the data, rather than by the code, provide a flag can't help. |
|
For some POCs, the customers could rebuild the cluster and continue the POC test if they could disable the partition feature. Otherwise, the test may be blocked. @tiancaiamao |
zimulala
reviewed
Oct 24, 2018
executor/show.go
Outdated
| @@ -620,6 +620,7 @@ func (e *ShowExec) fetchShowCreateTable() error { | |||
| if partitionInfo != nil { | |||
| // this if statement takes care of range columns case | |||
| if partitionInfo.Columns != nil && partitionInfo.Type == model.PartitionTypeRange { | |||
|
|
|||
|
Any idea about the error? @zimulala |
|
/run-all-tests |
zimulala
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Enable range typed table partition by default.
What is changed and how it works?
If the SQL is
create table ... partition by range ...,the
PartitionInfo.Enablefield will be set to trueSo this kind of table partition is handled.
Check List
Tests
Side effects
If a user create a range typed table partition with this TiDB binary, he can't degrade to an old version.
@shenli @ciscoxll