Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: fix mistaken conversion from outer join to inner join (cherry-pick #7689) #7899

Merged
merged 2 commits into from
Oct 15, 2018

Conversation

eurekaka
Copy link
Contributor

exclude upper level join conditions from predicates when simplifying
embedded outer join.

cherry-pick #7689

exclude upper level join conditions from predicates when simplifying
embedded outer join.
@eurekaka
Copy link
Contributor Author

/run-all-tests

@eurekaka eurekaka added type/bugfix This PR fixes a bug. sig/planner SIG: Planner labels Oct 15, 2018
@eurekaka
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 15, 2018
@eurekaka
Copy link
Contributor Author

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 15, 2018
@zz-jason zz-jason merged commit 4fe94f5 into pingcap:release-2.0 Oct 15, 2018
@eurekaka eurekaka deleted the release-2.0 branch October 15, 2018 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants