session: set Sleep state for process info #7826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenli
reviewed
Oct 6, 2018
| @@ -712,6 +712,9 @@ func (s *session) SetProcessInfo(sql string) { | |||
| State: s.Status(), | |||
| Info: sql, | |||
| } | |||
| if sql == "" { | |||
There was a problem hiding this comment.
If the query is sent through the binary protocol with prepare-execute method, will the sql be an empty string?
There was a problem hiding this comment.
No, SetProcessInfo will use OriginText of the execute statement. It is set in CompileExecutePreparedStmt.
|
/run-all-tests |
|
LGTM |
shenli
added
status/LGT2
coocood
added a commit
to coocood/tidb
that referenced
this pull request
Oct 8, 2018
coocood
added a commit
that referenced
this pull request
Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fixes #7825
What is changed and how it works?
Set the process command to
Sleepifsqlargument is emptyCheck List
Tests
Related changes